[ http://issues.apache.org/jira/browse/JDO-156?page=comments#action_12331876 ]
Michael Bouschen commented on JDO-156: -------------------------------------- Two minors: - QueryElementHolder: there is a private method rangeToString to create the range element for a single string query. I propose to add a similar method for a query created using the API methods. - QueryTest: the private methods compile and execute both have flags to determine whether itis a API or singleStringQuery: useAPIQuery and asStringString. How about uiosng the same flag (asStringString) in both cases? >From my point of view the patch is ready for check in. > Implement infrastructur to execute JDOQL queries as single queries or API > queries > --------------------------------------------------------------------------------- > > Key: JDO-156 > URL: http://issues.apache.org/jira/browse/JDO-156 > Project: JDO > Type: Improvement > Components: tck20 > Reporter: Michael Watzek > Assignee: Michael Watzek > Attachments: JDO-156.patch, JDO-156.patch2, JDO-156.patch3 > > Each concrete query test class contains code creating and executing JDO > queries using the API methods on javax.jdo.Query. Testing the JDO2 feature > "single string queries", we need a facility to write a JDOQL query once and > execute that as an API query and a single string query. > For this purpose, we propose to introduce a new class capable to hold all JDO > query elements, such as the canddidate class, the filter, etc. Instances of > that class may be used as factories for JDO query instances. > Moreover, we propose to introduce common methods in class Query_Test > compiling and executing query element holder instances as API queries and > single string queries. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
