| Hi Michael,
Thanks for the review.
On Jan 3, 2006, at 3:15 PM, Michael Bouschen (JIRA) wrote:
Michael Bouschen commented on JDO-269: --------------------------------------
The patch looks good.
One question: with the patch 0 cannot be used as valid id, because the code interprets id=0 as undefined id. If this is an issue we could store the value as a java.lang.Long. Then null means id is not specified. But I'm not sure whether this is worth the effort.
Yes, I thought of these cases but in practice I don't think change is warranted. We don't use 0 as the id, and it's a lot of work to change to a nullable type. Besides, the id field is the application identity field that should never be null.
Thanks,
Craig
Change setId methods to allow construction of Company Model classes with default constructor --------------------------------------------------------------------------------------------
Key: JDO-269 Project: JDO Type: Bug Components: tck20 Reporter: Craig Russell Assignee: Craig Russell Attachments: persistentinterfaces.patch
In order to use PersistenceManager.newInstance with the company model classes, we need to enable the setXXXId methods in the root classes. As it is right now, Person p = pm.newInstance(Person.class); p.setPersonId(5) results in IllegalStateException.
-- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: - For more information on JIRA, see:
|
smime.p7s
Description: S/MIME cryptographic signature
