Hi Craig, The patch works fine. Although I am still getting 3 failures for query.confwith datastoreidentity, but there are no compile errors.
On 2/13/06, Craig L Russell <[EMAIL PROTECTED]> wrote: > > Hi, > > Rather than delay the checkin of the updated test cases that we need > to verify the refined definition of how to treat projections of > variables, I separated out the updates to QueryTest and the new test > cases from the cleanup item to include the query filter with the > failure message. > > Sorry I didn't make this clear in the comments on the patches. > > If you can review the patch with the cleanup, I'll check it all in. > > Craig > > On Feb 13, 2006, at 6:01 AM, Karan Malhi wrote: > > > Michael: > > > > I had applied both the patches which craig had attached to the > > issue. I did > > not update my local copy. Probably that wouldve caused it. > > > > On 2/13/06, Michael Bouschen <[EMAIL PROTECTED]> wrote: > >> > >> Hi Karan, > >> > >> I tried the patch and it works on my side. I'm confused that you are > >> getting a NoSuchMethodErrors and not a compile error. Did you update > >> your workspace (svn update)? Craig already checked in part one of the > >> fix for JDO-304 which adds an overloaded version of the QueryTest > >> methods. > >> > >> Regards Michael > >> > >>> I still get 14 NoSuchMethodErrors > >>> > >>> On 2/12/06, Craig Russell (JIRA) <[EMAIL PROTECTED]> wrote: > >>> > >>>> [ http://issues.apache.org/jira/browse/JDO-304?page=all ] > >>>> > >>>> Craig Russell updated JDO-304: > >>>> ------------------------------ > >>>> > >>>> Attachment: Query.patch > >>>> > >>>> Please review this patch. > >>>> > >>>> There were 19 test cases affected by the change. Both versions > >>>> of the > >>>> check methods are available. The version without the filter > >>>> should only > >> be > >>>> used if the filter is null. This allows us to avoid updating the > >>>> other > >> test > >>>> cases. > >>>> > >>>> > >>>> > >>>> > >>>>> Query failure should print the query that failed in addition to > >>>>> the > >>>> > >>>> expected and actual results > >>>> > >> > >>>> ------------------------------------------------------------------- > >>>> ---------------------------- > >>>> > >>>>> Key: JDO-304 > >>>>> URL: http://issues.apache.org/jira/browse/JDO-304 > >>>>> Project: JDO > >>>>> Type: Improvement > >>>>> Components: tck20 > >>>>> Versions: JDO 2 beta > >>>>> Reporter: Craig Russell > >>>>> Priority: Minor > >>>>> Fix For: JDO 2 rc1 > >>>>> Attachments: Query.patch, QueryTest.patch > >>>>> > >>>>> The failure message doesn't contain the failing query: > >>>>> [java] There were 2 failures: > >>>>> [java] 1) testNoNavigation( > >>>> > >>>> org.apache.jdo.tck.query.result.VariableInResult > >> )junit.framework.AssertionFailedError: > >>>> Assertion A14.6.9-3 (VariableInResult) failed: > >>>> > >>>>> [java] Wrong query result: > >>>>> [java] expected: [Project(1, name orange, budget 2500000.99), > >>>> > >>>> Project(1, name orange, budget 2500000.99), Project(1, name orange, > >> budget > >>>> 2500000.99)] > >>>> > >>>>> [java] got: [Project(1, name orange, budget 2500000.99)] > >>>> > >>>> -- > >>>> This message is automatically generated by JIRA. > >>>> - > >>>> If you think it was sent incorrectly contact one of the > >>>> administrators: > >>>> http://issues.apache.org/jira/secure/Administrators.jspa > >>>> - > >>>> For more information on JIRA, see: > >>>> http://www.atlassian.com/software/jira > >>>> > >>>> > >>> > >>> > >>> > >>> -- > >>> Karan Malhi > >>> > >> > >> > >> -- > >> Michael Bouschen [EMAIL PROTECTED] Engineering GmbH > >> mailto:[EMAIL PROTECTED] http://www.tech.spree.de/ > >> Tel.:++49/30/235 520-33 Buelowstr. 66 > >> Fax.:++49/30/2175 2012 D-10783 Berlin > >> > > > > > > > > -- > > Karan Malhi > > Craig Russell > Architect, Sun Java Enterprise System http://java.sun.com/products/jdo > 408 276-5638 mailto:[EMAIL PROTECTED] > P.S. A good JDO? O, Gasp! > > > > -- Karan Malhi
