[
http://issues.apache.org/jira/browse/JDO-311?page=comments#action_12368327 ]
Craig Russell commented on JDO-311:
-----------------------------------
My preference is to print the entire class name in all places. But I would not
hold up this JIRA to make them all consistent (time permitting, of course)
grep printUnsupportedOptionalFeatureNotTested `find src/java -name "*java"`
src/java/org/apache/jdo/tck/api/persistencecapable/AbstractPersistenceCapableTest.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/api/persistencecapable/AbstractPersistenceCapableTest.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/api/persistencemanager/cache/EvictingWithRetainValuesFalse.java:
printUnsupportedOptionalFeatureNotTested("EvictingWithRetainValuesFalse",
"javax.jdo.option.RetainValues");
src/java/org/apache/jdo/tck/JDO_Test.java: protected void
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/lifecycle/HollowInstanceMaintainsPK.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/lifecycle/nontransactional/ModificationOfNontransactionalInstanceOutsideTransaction.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/lifecycle/nontransactional/ModificationOfNontransactionalInstanceOutsideTransaction.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/lifecycle/nontransactional/ModificationOfNontransactionalInstanceOutsideTransaction.java:
printUnsupportedOptionalFeatureNotTested(
src/java/org/apache/jdo/tck/mapping/CompletenessTest.java:
printUnsupportedOptionalFeatureNotTested(testName, token);
The usage in these five classes is inconsistent, so it's not a high priority to
make them all consistent. It's worth a low priority JIRA to make them
consistent, but I'd prefer that the first parameter to the
printUnsupportedOptionalFeatureNotTested be the fully qualified class name.
If there is ambiguity (see
org/apache/jdo/tck/lifecycle/nontransactional/ModificationOfNontransactionalInstanceOutsideTransaction)
we should probably qualify the class name with a method name, e.g.:
org.apache.jdo.tck.lifecycle.nontransactional.ModificationOfNontransactionalInstanceOutsideTransaction.testSameInstance()
It's wordy, but unambiguous.
I have no preference to changing them all with this JIRA or opening another
JIRA.
> Inheritance3 : should check if the JDO implementation supports
> "javax.jdo.option.mapping.RelationSubclassTable"
> ---------------------------------------------------------------------------------------------------------------
>
> Key: JDO-311
> URL: http://issues.apache.org/jira/browse/JDO-311
> Project: JDO
> Type: Bug
> Components: tck20
> Versions: JDO 2 beta
> Reporter: Andy Jefferson
> Assignee: Michael Watzek
> Fix For: JDO 2 final
> Attachments: JDO-311.patch
>
> The inheritance3 test should check whether PMF.supportedOptions contains
> "javax.jdo.option.mapping.RelationSubclassTable" before running the test.
> JPOX doesn't support this option yet the test still runs (and fails)
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
