Re: [jira] Resolved: (JDO-318) TCK should include some metadata files defined using the xsd header

[Craig L Russell]

Hi Michael,




Can someone from JPOX shed some light on this issue?

Thanks,

Craig

On Mar 2, 2006, at 12:56 PM, Michael Bouschen wrote:

I said "apparently so" because the tests seem to run, even if there are entries in the enhancer log file.

Hi Craig,

Hi Michael,

On Mar 2, 2006, at 6:40 AM, Michael Bouschen wrote:

Hi Craig,

sorry, I noticed this too late, but I think we have a problem.

- Does JPOX support XSD based JDO metadata files?

Apparently so.

...

Regards Michael

I'm not sure. I did a maven clean build and see a lot of errors in the enhancer log file (target/logs/enhancer/app-jpox.txt): 21:09:38,843 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/company/ package.jdo" at line 2 : Elementtyp "jdo" ist nicht deklariert. - Please check your specification of DTD and the validity of the MetaData XML that you have specified. 21:09:38,843 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/company/ package.jdo" at line 3 : Attribut "xmlns" ist nicht f™ür Element "jdo" deklariert. - Please check your specification of DTD and the validity of the MetaData XML that you have specified. 21:09:38,843 (main) ERROR [JPOX.MetaData] - MetaData Parser encountered an error in file "org/apache/jdo/tck/pc/company/ package.jdo" at line 4 : Attribut "xmlns:xsi" ist nicht f™ür Element "jdo" deklariert. - Please check your specification of DTD and the validity of the MetaData XML that you have specified.

- With this change some JDO metadata files use XSD to define their contents and the other use DTD. This means a JDO implementation that wants to pass the TCK *must* support both XSD and the DTD. - The JDO implementation cannot see upfront whether a particular JDO metadata file uses XSD or DTD, so it must check this before parsing the XML (the same as the XMLTest in api20 is doing).

Support for DTD is optional, so I propose all JDO metadata files should use XSD to define their contents as soon as JPOX supports this. What do you think?

Good idea. DTD is optional, so we should only use XSD for the TCK.

Good catch.

Craig

Regards Michael

[ http://issues.apache.org/jira/browse/JDO-318?page=all ]
Craig Russell resolved JDO-318:
-------------------------------
Resolution: Fixed

Transmitting file data ..........
Committed revision 382164.

svn commit -m "JDO-318 Change some .jdo and .orm files to use xsd" src/orm/datastoreidentity src/orm/applicationidentity Sending src/orm/applicationidentity/org/apache/jdo/tck/pc/ company/package-standard.orm Sending src/orm/applicationidentity/org/apache/jdo/tck/pc/ company/package-standard1.orm Sending src/orm/applicationidentity/org/apache/jdo/tck/pc/ company/package-standard2.orm Sending src/orm/applicationidentity/org/apache/jdo/tck/pc/ company/package-standard3.orm Sending src/orm/applicationidentity/org/apache/jdo/tck/pc/ company/package-standard4.orm Sending src/orm/datastoreidentity/org/apache/jdo/tck/pc/ company/ package-standard.orm Sending src/orm/datastoreidentity/org/apache/jdo/tck/pc/ company/ package-standard1.orm Sending src/orm/datastoreidentity/org/apache/jdo/tck/pc/ company/ package-standard2.orm Sending src/orm/datastoreidentity/org/apache/jdo/tck/pc/ company/ package-standard3.orm Sending src/orm/datastoreidentity/org/apache/jdo/tck/pc/ company/ package-standard4.orm svn commit -m "JDO-318 Change some .jdo and .orm files to use xsd" src/jdo/datastoreidentity src/jdo/applicationidentity Sending src/jdo/applicationidentity/org/apache/jdo/tck/pc/ company/package.jdo Sending src/jdo/applicationidentity/org/apache/jdo/tck/pc/ mylib/ package.jdo Sending src/jdo/applicationidentity/org/apache/jdo/tck/pc/ shoppingcart/package.jdo Sending src/jdo/datastoreidentity/org/apache/jdo/tck/pc/ company/ package.jdo Sending src/jdo/datastoreidentity/org/apache/jdo/tck/pc/ mylib/ package.jdo Sending src/jdo/datastoreidentity/org/apache/jdo/tck/pc/ shoppingcart/package.jdo

TCK should include some metadata files defined using the xsd header ------------------------------------------------------------------ -

Key: JDO-318
URL: http://issues.apache.org/jira/browse/JDO-318
Project: JDO
Type: Improvement
Components: tck20
Versions: JDO 2 rc1
Reporter: Craig Russell
Priority: Minor
Fix For: JDO 2 final
Attachments: xsd.patch

Currently, all .jdo, .orm, and .jdoquery metadata files use DTD to define their contents. I propose to use xsd to define a few of them.

--
Michael Bouschen [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED] http://www.tech.spree.de/
Tel.:++49/30/235 520-33 Buelowstr. 66
Fax.:++49/30/2175 2012 D-10783 Berlin

Craig Russell

Architect, Sun Java Enterprise System http://java.sun.com/products/ jdo

408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

--
Michael Bouschen                [EMAIL PROTECTED] Engineering GmbH
mailto:[EMAIL PROTECTED]        http://www.tech.spree.de/
Tel.:++49/30/235 520-33         Buelowstr. 66                   
Fax.:++49/30/2175 2012          D-10783 Berlin                  

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature