[
http://issues.apache.org/jira/browse/JDO-299?page=comments#action_12370301 ]
Craig Russell commented on JDO-299:
-----------------------------------
Looks good. A few comments.
1. The structure of the test classes is nonstandard. The classes in the file
should either become members of the SignatureTest class or put into their own
.java files.
2. The package structure of the classes needs to be improved. Should these
classes all be put into org.apache.jdo.tck.util perhaps?
3. There should be a class that extends JDO_Test that internally calls the main
method of the signature test. This could be a simple test class that adheres to
the pattern for the tck tests. I've attached a sample test that you can use as
a template.
4. The test needs to be integrated into the maven tck test framework. You will
need to update the maven.xml and project.properties to implement a maven system
property like "jdo.tck.signature.testdata" that is defined to be
${basedir}/src/conf/api20-signature.txt. This can then be retrieved by the
JUnit test program.
5. The output should be split so only errors are shown. Maybe a -q quiet option
and no output at all unless there is an error. Or a -v verbose option that
prints everything. Need to have a way for the output to be returned to the
calling program so it can be printed out as the test case exception message.
This would be just the -q output.
6. When combining the verbose output and the error output, there is a threading
problem. Maybe instead of using the system output and system error, you can use
parameter arguments with file names that direct output to the logs directory.
> Signature test needed checking compliance of implementations with JDO2.0 API
> ----------------------------------------------------------------------------
>
> Key: JDO-299
> URL: http://issues.apache.org/jira/browse/JDO-299
> Project: JDO
> Type: Task
> Components: tck20
> Reporter: Martin Zaun
> Assignee: Martin Zaun
> Priority: Minor
> Fix For: JDO 2 final
> Attachments: SignatureTest.java, api20_defs.txt
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira
