[ http://issues.apache.org/jira/browse/JDO-362?page=comments#action_12373185 ]
Michael Bouschen commented on JDO-362: -------------------------------------- The patch looks good! I looked at class NontransactionalWriteTest and I'm wondering whether it should be abstract. It is not a test itself it serves as superclass for a couple of test classes. It should not define a static field ASSERTION_FAILED since this belong to a concrete test class. If we decide to remove it, method beginAndCommitTransactionFails need to take the assertion string as an argument. What do you think? > NontransactionalWriteOptimisticRollback and other NontransactionalWriteTest > fail because OID is null. > ----------------------------------------------------------------------------------------------------- > > Key: JDO-362 > URL: http://issues.apache.org/jira/browse/JDO-362 > Project: JDO > Type: Bug > Components: tck20 > Versions: JDO 2 rc1 > Reporter: Christian Ernst > Assignee: Craig Russell > Fix For: JDO 2 final > Attachments: nontransactionalwrite.patch > > In the super class of all NontransactionalWriteTest's : > org.apache.jdo.tck.lifecycle.NontransactionalWriteTestcreateAndModifyVersionedPCPoint.createAndModifyVersionedPCPoint() > an OID is obtained for a transient Instance which will be than always null > because of A.12.5.6.-14 > There seems to be missing a pm.makePersistent(instance); -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
