[ 
http://issues.apache.org/jira/browse/JDO-324?page=comments#action_12443602 ] 
            
Craig Russell commented on JDO-324:
-----------------------------------

Looks good. Just a couple of comments.

1. The failOnError should be outside the try...finally block, to make sure you 
see the error messages.

2. The indentation of " if (pntVerify.getX() != 33 " block is off.

3. I think you need to verify the values when doRefresh is false. You might not 
catch an exception but commit the change. I'd put the retrieval of the value 
outside the if(doRefresh) and check the values:

if (doRefresh) {
pntVerify == 33, 33
} else {
pntVerify == 22, 22
}


> Derby "ERROR 40XL1" in multithreaded test "RefreshAllNoParameterSideEffects"
> ----------------------------------------------------------------------------
>
>                 Key: JDO-324
>                 URL: http://issues.apache.org/jira/browse/JDO-324
>             Project: JDO
>          Issue Type: Bug
>          Components: tck20
>    Affects Versions: JDO 2 rc1
>            Reporter: Jörg von Frantzius
>         Assigned To: Michelle Caisse
>         Attachments: derby-dsid-pm-junit.txt, 
> RefreshAllNoParameterSideEffects.java
>
>
> When using latest JPOX nightly (01-Mar-2006 04:21), I get a "ERROR 40XL1: A 
> lock could not be obtained within the time requested" Derby error (see next 
> attachment for log file). This happens while running 
> RefreshAllNoParameterSideEffects, which is multithreaded, and it happens for 
> both threads.
> This is with Windows XP SP2 and JDK 1.4.2_09 on a dual core machine. Maybe 
> the fact that it is dual core leads to different timing than single core?

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to