Hi Matthew, Big changes; thanks for taking care of this.
I think it's now time to branch, even though there is still the issue of the extraneous message when running in the api20 directory:
#maven build
...
[junit] Running javax.jdo.JDOHelperConfigTest
[Fatal Error] :-1:-1: Premature end of file.
and the errors when running from the trunk https://issues.apache.org/
jira/browse/JDO-484 :
#maven jdo20.build ...[junit] Tests run: 19, Failures: 9, Errors: 0, Time elapsed: 0.103 sec
[junit] [ERROR] TEST javax.jdo.JDOHelperConfigTest FAILED
Craig
On Jun 6, 2007, at 11:44 PM, Matthew T. Adams wrote:
I uploaded a patch -- it's now fixed. I'll go ahead and commit the changessince it's blocking. Let me know if there are further problems. -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 06, 2007 5:41 PM To: [email protected] Subject: Re: Test failure in api20 Hi Matthew, Can you give us some idea of where you think the problem is? This is blocking the branch of api2. If you can tell us something about what you suspect the issue is I can try to fix it. Craig On Jun 6, 2007, at 11:05 AM, Matthew T. Adams wrote:It's my fault, but I can't fix it right now; I'll look at it as soon as I can... -----Original Message----- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 06, 2007 10:08 AM To: [email protected] Subject: Re: Test failure in api20 FYI, I see the same errors after the recent check-ins. -- Michelle Craig L Russell wrote:Yes, the text of the message is different. Craig On Jun 6, 2007, at 8:12 AM, Michael Bouschen wrote:Hi Craig, I guess these are different errors from the ones described in https://issues.apache.org/jira/browse/JDO-484, correct? Regards MichaelHi, I get this error when running the api20 maven build from the tip of the trunk: Testsuite: javax.jdo.JDOHelperConfigTest Tests run: 19, Failures: 0, Errors: 18, Time elapsed: 0.124 sec Testcase: testPositive00_PMF0_GetNamedPMFProperties (javax.jdo.JDOHelperConfigTest): Caused an ERROR org.apache.tools.ant.AntClassLoader atjavax.jdo.JDOHelperConfigTest.testPositive00_PMF0_GetNamedPMFPrope rti es(JDOHelperConfigTest.java:57) The error occurs at the line that constructs a new class loader: URLClassLoader loader = new JDOConfigTestClassLoader( JDOCONFIG_CLASSPATH_PREFIX, (URLClassLoader) getClass().getClassLoader()); I don't recognize the error. The stack trace doesn't show where in the constructor the error is. Any clues? Craig public class JDOConfigTestClassLoader extends URLClassLoader { public JDOConfigTestClassLoader(String partialPathToIgnore, URLClassLoader unparent) { this(new String[]{partialPathToIgnore}, unparent); } public JDOConfigTestClassLoader(String[] partialPathsToIgnore, URLClassLoader unparent) { super(new URL[]{}, null); addNonTestURLs(partialPathsToIgnore == null ? new String[] {} : partialPathsToIgnore, unparent); } // HACK: need to identify a better way of controlling test classpath protected void addNonTestURLs(String[] partialPathsToIgnore, URLClassLoader unparent) { URL[] urls = unparent.getURLs(); for (int i = 0; i < urls.length; i++) { URL url = urls[i]; String urlString = url.toString();for (int j = 0; j < partialPathsToIgnore.length; j+ +) {if (urlString.indexOf(partialPathsToIgnore[j]) == -1) { addURL(url); } } } } } Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/ products/ jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!-- [EMAIL PROTECTED] Engineering GmbH Tel.: +49/(0)30/235 520-33 Buelowstr. 66 Fax.: +49/(0)30/217 520-12 10783 Berlin mailto:[EMAIL PROTECTED] Geschaeftsfuehrung: Anna-Kristin Proefrock Sitz Berlin, Amtsgericht Charlottenburg, HRB 564 52Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/ jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!
Craig Russell Architect, Sun Java Enterprise System http://java.sun.com/products/jdo 408 276-5638 mailto:[EMAIL PROTECTED] P.S. A good JDO? O, Gasp!
smime.p7s
Description: S/MIME cryptographic signature
