[
https://issues.apache.org/jira/browse/JDO-515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12519473
]
Craig Russell commented on JDO-515:
-----------------------------------
I suppose we should change all of the defaults from UNKNOWN to UNSPECIFIED in
all the annotations.
[Bruiser:javax/jdo/annotations] clr% grep UNKNOWN *
DatastoreIdentity.java: IdGeneratorStrategy strategy() default
IdGeneratorStrategy.UNKNOWN;
Discriminator.java: default DiscriminatorStrategy.UNKNOWN;
DiscriminatorStrategy.java: UNKNOWN,
Element.java: ForeignKeyAction deleteAction() default
ForeignKeyAction.UNKNOWN;
Element.java: ForeignKeyAction updateAction() default
ForeignKeyAction.UNKNOWN;
ForeignKeyAction.java: UNKNOWN,
IdGeneratorStrategy.java: UNKNOWN,
IdentityType.java: UNKNOWN,
Join.java: ForeignKeyAction deleteAction() default ForeignKeyAction.UNKNOWN;
Key.java: ForeignKeyAction deleteAction() default ForeignKeyAction.UNKNOWN;
Key.java: ForeignKeyAction updateAction() default ForeignKeyAction.UNKNOWN;
PersistenceCapable.java: IdentityType identityType() default
IdentityType.UNKNOWN;
PersistenceModifier.java: UNKNOWN,
Persistent.java: default PersistenceModifier.UNKNOWN;
Persistent.java: IdGeneratorStrategy valueStrategy() default
IdGeneratorStrategy.UNKNOWN;
Value.java: ForeignKeyAction deleteAction() default ForeignKeyAction.UNKNOWN;
Value.java: ForeignKeyAction updateAction() default ForeignKeyAction.UNKNOWN;
> Allow custom settings for some annotation enum values
> -----------------------------------------------------
>
> Key: JDO-515
> URL: https://issues.apache.org/jira/browse/JDO-515
> Project: JDO
> Issue Type: Improvement
> Components: api2
> Reporter: Andy Jefferson
> Fix For: JDO 2 maintenance release 1
>
>
> JDO2.1 annotations utilise some enums defining the acceptable values for
> various strategies. The following need changing to allow implementations to
> provide custom values.
> @Persistence "valueStrategy", @DatastoreIdentity "strategy" are of the type
> IdGenerationStrategy. Changes required :
> 1. IdGenerationStrategy needs UNKNOWN changing to UNSPECIFIED.
> 2. @Persistence : add "customValueStrategy"
> 3. @DatastoreIdentity : add "customStrategy"
> @Inheritance "strategy" is of type InheritanceStrategy. Changes required :
> 1. InheritanceStrategy needs UNSPECIFIED adding.
> 2. @Inheritance : change "strategy" to have default of UNSPECIFIED
> 3. @Inheritance : add "customStrategy"
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
