[ 
https://issues.apache.org/jira/browse/JDO-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539163
 ] 

Craig Russell commented on JDO-446:
-----------------------------------

Two questions. 

1. The javadoc for param parameter[s] say
+     * @param parameters the actual values of the subquery parameters

But it isn't the actual values, it's the name of the expression in the outer 
query to bind the parameter. The description is ok, but the @param should 
probably say 
* @param parameter the expression from the outer query to bind the parameter in 
the subquery

2. Should we consider one more method, with two arguments, that has the 
candidate collection be the extent of the candidate class of the subquery? This 
would avoid the need for passing null as the candidateCollectionExpression. 
Might be too much of a corner case.


> Add subqueries APIs
> -------------------
>
>                 Key: JDO-446
>                 URL: https://issues.apache.org/jira/browse/JDO-446
>             Project: JDO
>          Issue Type: New Feature
>          Components: api2, api2-legacy
>    Affects Versions: JDO 2 final
>            Reporter: Michelle Caisse
>            Assignee: Michael Bouschen
>             Fix For: JDO 2 maintenance release 1
>
>         Attachments: subquery-api.patch
>
>
> In 14, add subqueries to permit e.g. select from Employee where this.salary > 
> (select avg(salary) from Employee)

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to