Re: [VOTE] Change signature of new method evictAll

[Craig L Russell]

We're really close to the end of 2.1 and I'd like to make the change now to deprecate the (Object, boolean) forms of the methods and introduce the (boolean, Object) forms in DataStoreCache.

Craig

On Jan 25, 2008, at 9:38 AM, Michael Bouschen wrote:

Hi Craig,

+1 make the change now.





Regards Michael

There might be one issue: method DataStoreCache.evictAll is there since 2.0, so we might have a backward compatibility issue here. I still vote for making the change now, but maybe we have to keep the old version and deprecate it. What do you think? Another question: how about methods DataStoreCache.pin and DataStoreCache.unpin? Do we want to swap the arguments (Class, boolean) here, too?

We have a method new for JDO 2.1 in PersistenceManager and DataStoreCache evictAll(Class cls, boolean subclasses). This pattern would make it awkward to add a method evictAll(Class... classes, boolean subclasses) if we decide it's valuable.

+1 make the change now
-1 don't change (why?)

The vote will close Jan 28.

Craig
Craig Russell

Would it make sense to change the signature to evictAll(boolean subclasses, Class cls) now to avoid the issue later? It's a trivial change now but a deprecation issue later. Architect, Sun Java Enterprise System http://java.sun.com/products/ jdo

408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

--
[EMAIL PROTECTED] Engineering GmbH  Tel.: +49/(0)30/235 520-33
Buelowstr. 66                Fax.: +49/(0)30/217 520-12

10783 Berlin mailto:[EMAIL PROTECTED] Geschaeftsfuehrung: Martin Weber

Sitz Berlin, Amtsgericht Charlottenburg, HRB 564 52

Craig Russell
Architect, Sun Java Enterprise System http://java.sun.com/products/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

smime.p7s
Description: S/MIME cryptographic signature