[
https://issues.apache.org/jira/browse/JDO-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12569426#action_12569426
]
Craig Russell commented on JDO-576:
-----------------------------------
Looking at svn org.jpox.jdo.JDOPersistenceManagerFactory it looks like the
signature of the getPersistenceManagerFactory(Map, Map) has the arguments
reversed:
/**
123 * Return a new PersistenceManagerFactoryImpl with options set
according to the given properties and
124 * given overrides.
125 * @param props Map of properties to initialise the PMF with
126 * @param overrides Map of properties to override the supplied props
(if any)
127 * @return A PersistenceManagerFactoryImpl with options set according
to the given Properties
128 */
129 public synchronized static PersistenceManagerFactory
getPersistenceManagerFactory(Map props, Map overrides)
130 {
131
The signature should be getPersistenceManagerFactory(Map overrides, Map props)
Usually I like to have unambiguous parameters but in this case, having both
overrides and props being Map types, it's unavoidable.
Here's a patch:
- public synchronized static PersistenceManagerFactory
getPersistenceManagerFactory(Map props, Map overrides)
+ public synchronized static PersistenceManagerFactory
getPersistenceManagerFactory(Map overrides, Map props)
> Create new tests for getting a pmf using jdoconfig.xml
> ------------------------------------------------------
>
> Key: JDO-576
> URL: https://issues.apache.org/jira/browse/JDO-576
> Project: JDO
> Issue Type: Test
> Components: tck2, tck2-legacy
> Reporter: Michelle Caisse
> Assignee: Michelle Caisse
> Fix For: JDO 2 maintenance release 1
>
>
> New tests are needed to test getting a persistence manager factory with
> JDOHelper.getPersistenceManagerFactory() and
> JDOHelper.getPersistenceManagerFactory(String name);
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
