[
https://issues.apache.org/jira/browse/JDO-583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12585627#action_12585627
]
Craig Russell commented on JDO-583:
-----------------------------------
Adding Apache headers to src/conf/jdo-2_1-signatures.txt involves two changes:
1. Update the signatures.txt file to have the standard Apache java source code
comment block at the beginning.
2. Modify the parser of the file to skip comments. There is already a method
used to skip white space, and this method should be updated to skip comments as
well. Take a look at
"tck2/src/java/org/apache/jdo/tck/util/signature/SignatureVerifier.java" line
836 and add code to detect the "/*" sequence and skip through the input stream
until you find a trailing "/*" and then continue to skip white space.
> Add license headers to source files.
> ------------------------------------
>
> Key: JDO-583
> URL: https://issues.apache.org/jira/browse/JDO-583
> Project: JDO
> Issue Type: Bug
> Components: tck2, tck2-legacy
> Affects Versions: JDO 2 maintenance release 1
> Reporter: Craig Russell
> Assignee: Matthew T. Adams
> Fix For: JDO 2 maintenance release 2
>
>
> RAT reveals files that need Apache license headers:
> jdo2-tck-2.1/src/conf/jdo-2_1-signatures.txt
> jdo2-tck-2.1/src/java/org/apache/jdo/tck/pc/company/
> CompanyFactoryNewInstance.java
> jdo2-tck-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/
> shoppingcart.argo.uml\
> jdo2-tck-legacy-2.1/src/conf/jdo-2_1-signatures.txt
> jdo2-tck-legacy-2.1/src/uml/org/apache/jdo/tck/pc/shoppingcart/
> shoppingcart.argo.uml
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
