Hi Ilan,

I'll take a closer look at this when I get a chance.

Craig

On Nov 5, 2008, at 6:09 AM, Ilan Kirsh (JIRA) wrote:

GetObjectIdForPersistentInterface - Implementation Class / PICompany / ICompany Mess
-------------------------------------------------------------------------------------

                Key: JDO-611
                URL: https://issues.apache.org/jira/browse/JDO-611
            Project: JDO
         Issue Type: Test
         Components: tck2
   Affects Versions: JDO 2 maintenance release 2
           Reporter: Ilan Kirsh


I have two issues with this test:

(1)
IMO, PICompany should be written instead of ICompany:

(a)
ICompany icompany = (ICompany)pm.newInstance(PICompany.class);
 instead of:
ICompany icompany = (ICompany)pm.newInstance(ICompany.class);

and:

(b)
addTearDownClass(PICompany.class);
 instead of:
addTearDownClass(ICompany.class);

ICompany is not persistence capable, so the implementation does not have to handle it.

(2)
I think that the following check is wrong:

if (icompanyOidClass != icompany.getClass())

icompany.getClass()  => the physical internal implementation class
icompanyOidClass  => the logical interface (PICompany)

Actually and exception should be thrown if (icompanyOidClass == icompany.getClass())


--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Craig L Russell
Architect, Sun Java Enterprise System http://db.apache.org/jdo
408 276-5638 mailto:[EMAIL PROTECTED]
P.S. A good JDO? O, Gasp!

Attachment: smime.p7s
Description: S/MIME cryptographic signature

Reply via email to