[
https://issues.apache.org/jira/browse/JDO-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16639607#comment-16639607
]
Andy Jefferson commented on JDO-652:
------------------------------------
If adding generics to the returned NumericExpression on those methods in
NumericExpression, suggest that log, exp ought to be NumericExpression<Double>,
certainly if cos, sin, tan etc are going to be.
As mentioned earlier, I would make the methods lt, gt, etc on
ComparableExpression take in
{{ComparableExpression<? extends T> expr}}
rather than just ComparableExpression<T>. Hard to see if you have this change
given the number of patch files there
I have no particular preference on IfThenElse methods. What you have is fine by
me.
Separate issue : in recent source control tools we don't need to faff about
with patches; people can just have a separate branch to develop changes in and
then it is immediately visible what the overall API is. Also developers don't
need to leave their changes in separate files that others have to apply to be
able to see them; the branch can be downloaded and ran directly without
manipulation. Wouldn't that be a more convenient way of developing features?
Then, when it is agreed, the changes are just applied to the master branch. FWIW
> Provision of a typesafe refactor-friendly query capability for JDOQL
> --------------------------------------------------------------------
>
> Key: JDO-652
> URL: https://issues.apache.org/jira/browse/JDO-652
> Project: JDO
> Issue Type: New Feature
> Components: api, specification, tck
> Reporter: Andy Jefferson
> Assignee: Michael Bouschen
> Priority: Major
> Fix For: JDO 3.2
>
> Attachments: JDO-652-api-ifTheElse.txt, JDO-652-api-patch-Andy.txt,
> JDO-652-patch4.txt, typesafe.patch, typesafe_manifest.patch
>
>
> There are various querying capabilities of this type around. JPA2 has its
> Criteria query API. Third party solutions like QueryDSL also exist, in its
> case providing a JDOQL implementation (as well as JPQL, and HQL). We should
> seriously consider introducing something along these lines in the JDO2.4
> timeframe.
> There is a comparison of JPA Criteria with QueryDSL over at
> http://source.mysema.com/forum/mvnforum/viewthread_thread,49
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
