[ https://issues.apache.org/jira/browse/JDO-652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907136#comment-16907136 ]
Tilmann Zäschke commented on JDO-652: ------------------------------------- I also had a look at the new Section in Ch14, looks good. Some minor comments: 14.10.1: * I think "chapter"is usually capitalized -> "Chapter" (2x) 14.10.3: * JDOTypedQuery should be JDOQLTypedQuery 14.10.6 * ComparableExpressions: Why is it called `geeq` instead of `gteq`? That seems inconsistent. Maybe even `gtEq` and `ltEq`? * NumericExpression: change "q query" to "a query" * NumericExpressions: missing ": " at end of line * "Persistent Fields" -> "Persistent fields" 14.10.7 + 8: * As mentioned by Craig, I think a different font for methods/variables may make reading the text easier: 'distinct', 'order by', 'ComparableExpression'. * Change "JDOQLTypedQuery method" to "The JDOQLTypedQueryMethod" (2x) * Change "Methods asc [...]" at beginning of sentence to "The methods asc [...]" 14.10.13 * Double space before JDOQLTypedQuery We should check the following in the generated PDF, because it looked different in LibreOffice than in OpenOffice: 14.10.3 + 7 + 8 + 10 + 11 * We need to double check the section headers in the generated document. It looks fine in OpenOffice, but in LibreOffice the "Typed Query Interface" and the other headers are not considered headers (just normal text) and have no numbering. 14.10.10 + 12 * Some of the lines have Times New Roman instead of Courier New font > Provision of a typesafe refactor-friendly query capability for JDOQL > -------------------------------------------------------------------- > > Key: JDO-652 > URL: https://issues.apache.org/jira/browse/JDO-652 > Project: JDO > Issue Type: New Feature > Components: api, specification, tck > Reporter: Andy Jefferson > Assignee: Michael Bouschen > Priority: Major > Fix For: JDO 3.2 > > Attachments: Ch14-Query.odt, JDO-652-api-ifTheElse.txt, > JDO-652-api-patch-Andy.txt, JDO-652-patch4.txt, typesafe.patch, > typesafe_manifest.patch > > > There are various querying capabilities of this type around. JPA2 has its > Criteria query API. Third party solutions like QueryDSL also exist, in its > case providing a JDOQL implementation (as well as JPQL, and HQL). We should > seriously consider introducing something along these lines in the JDO2.4 > timeframe. > There is a comparison of JPA Criteria with QueryDSL over at > http://source.mysema.com/forum/mvnforum/viewthread_thread,49 -- This message was sent by Atlassian JIRA (v7.6.14#76016)