clr-apache commented on pull request #5: URL: https://github.com/apache/db-jdo-site/pull/5#issuecomment-626425434
Hi Tobias, > On May 10, 2020, at 5:56 AM, Tobias Bouschen <notificati...@github.com> wrote: I was wondering about "tobous" and thought it might be you. > > This is my first contribution to an Apache project and it is not clear to me whether I need to sign the ICLA <https://www.apache.org/licenses/contributor-agreements.html> for this contribution. > > The wiki page states that all "contributions" require this agreement but I couldn't find a reference to it on the "Contributing" page of this repo or the general guidelines for new contributors <https://www.apache.org/dev/contributors.html>. From looking around and reading a couple of mailing list entries[1] <http://mail-archives.apache.org/mod_mbox/www-infrastructure-dev/201112.mbox/%3ca603ffce-623b-43e9-87f8-39baa51c7...@gbiv.com%3E>[2] <http://mail-archives.apache.org/mod_mbox/www-legal-discuss/201606.mbox/%3ccanq7ko_z_cfflju_7hoonno4duo7bxufdzutk3yntsnxvu1...@mail.gmail.com%3E>, it seems like the agreement is not necessary, but I still wanted to make sure. > > The wiki page needs to be updated. It should say "significant contributions" require an ICLA. The issue is whether someone who contributes a change that is then challenged in some way and there is no ICLA on file governing the contribution. In this case, there is no issue. So, welcome to the project. We hope to see more from you. Regards, Craig > Commit contents > > Adds a footer to the main index page. This was done to create a unified > styling for the website. > > Moves the page "JDO v JPA : ORM" to the section "General" (instead of > "Metadata") so that it matches its entry in the menu bar. > > Fixes the highlighted text for the menu bar entry "API Usage". > > Removes spaces from the names of the menu bar entries to avoid > inconsistent spacing when highlighting or not highlighting the name. > > Adjusts the search box to search on the site "db.apache.org/jdo". > > Adjusts the styling of the footer. Changes the color to white and the > background color to gray. Centers the links in the footer. > > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/db-jdo-site/pull/5 <https://github.com/apache/db-jdo-site/pull/5> > Commit Summary > > Fix minor issues in site menu > File Changes > > M src/main/asciidoc/index.adoc <https://github.com/apache/db-jdo-site/pull/5/files#diff-c93983d6341930bcd00e664025a21853> (1) > M src/main/asciidoc/jdo_v_jpa_orm.adoc <https://github.com/apache/db-jdo-site/pull/5/files#diff-a469bd6552fb4f106911358acdcc3d90> (2) > M src/main/template/document.html.erb <https://github.com/apache/db-jdo-site/pull/5/files#diff-84f1a9cb1c9523fc450e57f332bdbfbe> (28) > Patch Links: > > https://github.com/apache/db-jdo-site/pull/5.patch <https://github.com/apache/db-jdo-site/pull/5.patch> > https://github.com/apache/db-jdo-site/pull/5.diff <https://github.com/apache/db-jdo-site/pull/5.diff> > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub <https://github.com/apache/db-jdo-site/pull/5>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD4M6RHLOG5O4EE3BZRV4RLRQ2QBTANCNFSM4M5HNZXA>. > Craig L Russell c...@apache.org ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
