> Probably because git gives the return code 1 if there is
> nothing to push.

To be more precise, git returns the exit code 1 if you try to commit something while the staging area is empty. I will adjust the action to check whether the staging area is empty and end early in such cases to avoid the failure.

On 2/5/21 8:00 PM, Tobias Bouschen wrote:
I forgot to hit 'reply list' for my last mail. Sorry about that.


 > Same here.

 > I reran the job, it is not obvious to me why it fails:

> https://github.com/apache/db-jdo-site/runs/1841121479?check_suite_focus=true

Re-running the job should not help as all the changes have already been successfully deployed to the 'publish' branch. See https://github.com/apache/db-jdo-site/commit/c124f1d8464e0ddaf13645324588c74d7ed46b26

From skimming the log, the action ended without having to commit anything as there were no changes. I am not sure why this caused the action to fail. Probably because git gives the return code 1 if there is nothing to push. I will have a look at it.

Re-running a successful job was not something I thought about when writing the script (I did not even know GitHub allowed this; as far as I knew, only failed jobs could be re-triggered). I will see if I can adjust the behavior to 'fail' gracefully if there is nothing to commit.

On 2/5/21 7:51 PM, Tobias Bouschen wrote:
I am pretty sure that this is unrelated. The 'red x' is solely related to GitHub jobs, specifically the deployment of the GitHub pages in this case. If you hover over the failed build entries (or look at a failed run, e.g. https://github.com/apache/db-jdo-site/runs/1834023054), it also specifies they only regard the GitHub pages build/deployment.

Reply via email to