hboutemy commented on pull request #36:
URL: https://github.com/apache/db-jdo/pull/36#issuecomment-1043303823


   > This will never detect problems resulting from different environments...
   
   you're right. There are many reproducibility problems that are not because 
environments are different, but even on the same env, 2 builds give different 
results: if you look at the jdo issue for 3.2 release, it's not because of 
environment 
https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/jdo/jdo-3.2.diffoscope
 .
   
   > Should the second line be `mvn clean verify artifact:compare`?
   
   as you wish: output is expected to be done at `package` stage, `verify` is 
not expected to add anything. But you can and should customize the command to 
match your build expectations
   
   > At what point in the release process is this best executed?
   
   it is not expected to be executed during the release process: it's expected 
to be executed when you develop.
   Once the release is done, people outside your project will try to rebuild 
(obviously with different environment) and check they can get the same output 
as you: if they find an issue, it's too late for the release, it will have to 
be fixed for the next release, so during the development phase before the next 
release: hence the provided test commands to run during development
   
   Once you have a release that was reproducible, in general, next ones are 
also reproducible, because build structure does not change often.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to