[ https://issues.apache.org/jira/browse/JDO-824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tilmann Zäschke updated JDO-824: -------------------------------- Fix Version/s: (was: JDO 3.2.2) Description: The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable. This should probably be changed to be more specific, in the current state it would even ignore OutOfMemoryException, which is probably not what is intended here. All occurrences: * nonBinaryCompatibleGet() * nonBinaryCompatibleIs() * nonBinaryCompatibleMakeDirty() Otherwise we should document why this okay. I am currently unsure why ignoring *any* exception is okay here? was: The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown Exceptions of type Throwable. This should probably be changed to be more specific, in the current state it would even ignore OutOfMemoryException, which is probably not what is intended here. > JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores Throwable > -------------------------------------------------------------- > > Key: JDO-824 > URL: https://issues.apache.org/jira/browse/JDO-824 > Project: JDO > Issue Type: Task > Components: api > Affects Versions: JDO 3.2, JDO 3.2.1 > Reporter: Tilmann Zäschke > Priority: Major > > The method JDOImplHelper.nonBinaryCompatibleMakeDirty() ignores all thrown > Exceptions of type Throwable. > This should probably be changed to be more specific, in the current state it > would even ignore > OutOfMemoryException, which is probably not what is intended here. > All occurrences: > * nonBinaryCompatibleGet() > * nonBinaryCompatibleIs() > * nonBinaryCompatibleMakeDirty() > Otherwise we should document why this okay. > I am currently unsure why ignoring *any* exception is okay here? -- This message was sent by Atlassian Jira (v8.20.10#820010)