Attendees: Michael Bouschen, Tilmann Zäschke, Tobias Bouschen, Craig Russell

Next meeting: Thursday March 23 1200 PDT 2000 CET

Agenda:

1. JIRA JDO-819 "Code quality analysis" 
https://issues.apache.org/jira/browse/JDO-819
   JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" 
https://issues.apache.org/jira/browse/JDO-823

Sonarcloud link: https://sonarcloud.io/summary/overall?id=db-jdo

* Standard outputs shoudl not be used to log anything:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS106&severities=MAJOR&types=CODE_SMELL&id=db-jdo
InstallSchema won't fix
Enhancer won't fix
JDOException remove the offending printStackTrace() which will use the 
superclass implementation 
AI Michael

* Unsed type parameters shoudl be removed:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS2326&severities=MAJOR&types=CODE_SMELL&id=db-jdo
EnumExpression has unused type T breaking change mark won't fix until 3.0
At the time we change this we will also need a TCK test
Volunteer needed

* Exception classes should be immutable:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1165&severities=MINOR&types=CODE_SMELL&id=db-jdo
JDOException fields nested and failed should be marked final
AI Tobias
inPrintStackTrace is modified during the execution of the method 
AI Tobias look into it; maybe already a test case to try

* Arrays should be be copied using loops:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3012&severities=MINOR&types=CODE_SMELL&id=db-jdo
* Arrays should not be created for varargs parameters:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3878&severities=MINOR&types=CODE_SMELL&id=db-jdo
* Loops shoudl not contain more than a single "break" or "continue"
  statement:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS135&severities=MINORtypes=CODE_SMELL&id=db-jdo
* Mutable fields sould not be "public static":
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS2386&severities=MINOR&types=CODE_SMELL&id=db-jdo
* Type parameter names should comply with naming convention:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS119&severities=MINOR&types=CODE_SMELL&id=db-jdo
* Unused local variables should be removed:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS1481&severities=MINOR&types=CODE_SMELL&id=db-jdo

* Cognitive Complexity of methods should not be too high:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3776&severities=CRITICAL&types=CODE_SMELL&id=db-jdo

* Raw types should not be used:
  
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3740&severities=MAJOR&id=db-jdo



2. JIRA JDO-709 "Standardize field/property converters" 
https://issues.apache.org/jira/browse/JDO-709

3. JIRA JDO-822: "Verify compatibility with JDK 20" 
https://issues.apache.org/jira/browse/JDO-822

4. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" 
https://issues.apache.org/jira/browse/JDO-812

5. Other issues

Action Items from weeks past:

[Nov 23 2022] AI Tilmann follow up with Andy/DataNucleus for his advice on 
JDO-709.
[Oct 20 2022] AI Craig update the JIRA JDO-709 to request a test case using 
annotations and results of the test.
[Dec 09 2021] AI Craig: Try to contact all current/former participants in JDO 
development and see if and how they want to be recognized on the JDO and DB web 
sites.https://db.apache.org/whoweare.html
[Oct 07 2021] AI Craig send a private message to all JSR-243 Expert Group 
members asking if they wish to continue.
[Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr accounts
[Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL 
datastores" https://issues.apache.org/jira/browse/JDO-651

Craig L Russell
c...@apache.org

Reply via email to