tzaeschke opened a new pull request, #83: URL: https://github.com/apache/db-jdo/pull/83
As part of https://issues.apache.org/jira/browse/JDO-823, this PR attempt to clean up code issues in the `Enhancer`. Specifically: - [x] Reduce code complexity of `execute()`. Done. - [ ] ~~Fix problem with `ClassLoader` not being treated as resource in the try-catch block.~~ - [ ] Analyze problem with `classes` only ever being used for `"testdata"`. Is this intentional? Why does it work at all? The ClassLoader problem reported by SonarCloud is considered a false positive: 1) While the class loader is created inside the try-catch block, it is also assigned, i.e. it leaves the scope. It should definitely **not** be closed in this try-catch block under any circumstances. 2) Introducing an "outer" try-catch block to close it would also be wrong, the class loader will be closed automatically when the current thread ends. I don't think it is even possible to close (or detatch) the class loader before the thread ends. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
