[GH] JDO-844: Add SampleReadQuery test methods with variables of type String (db-jdo)

[via GitHub]

mboapache commented on code in PR #97:
URL: https://github.com/apache/db-jdo/pull/97#discussion_r1835755342


##########
tck/src/main/java/org/apache/jdo/tck/pc/companyAnnotatedPC/PCAppPerson.java:
##########
@@ -294,6 +298,24 @@ public void setPhoneNumbers(Map<String, String> 
phoneNumbers) {
     this._phoneNumbers = (phoneNumbers != null) ? new HashMap<>(phoneNumbers) 
: null;
   }
 
+  /**
+   * Get the map of languages as an unmodifiable Set.
+   *
+   * @return The set of languages, as an unmodifiable set.
+   */
+  public Set<String> getLanguages() {
+    return Collections.unmodifiableSet(_languages);
+  }
+
+  /**
+   * Set the languages set to be in this person.
+   *
+   * @param languages The set of languages for this person.
+   */
+  public void setLanguages(Set<String> languages) {
+    this._languages = languages;

Review Comment:
   Good catch.



##########
tck/src/main/java/org/apache/jdo/tck/pc/companyAnnotatedFC/FCDSPerson.java:
##########
@@ -297,6 +305,24 @@ public void setPhoneNumbers(Map<String, String> 
phoneNumbers) {
     this.phoneNumbers = (phoneNumbers != null) ? new HashMap<>(phoneNumbers) : 
null;
   }
 
+  /**
+   * Get the map of languages as an unmodifiable Set.
+   *
+   * @return The set of languages, as an unmodifiable set.
+   */
+  public Set<String> getLanguages() {
+    return Collections.unmodifiableSet(languages);
+  }
+
+  /**
+   * Set the languages set to be in this person.
+   *
+   * @param languages The map of phoneNumbers for this person.
+   */
+  public void setLanguages(Set<String> languages) {
+    this.languages = languages;

Review Comment:
   Good catch.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jdo-dev-unsubscr...@db.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org