FYI... If you are not subscribed to users@ this is the kind of stuff that is discussed there...
Craig > Begin forwarded message: > > From: Hans Van Akelyen <hans.van.akel...@gmail.com> > Subject: Re: [ANNOUNCE] For projects with Git(Hub) repositories: .asf.yaml > parser has upgraded > Date: March 13, 2025 at 03:58:47 PDT > To: us...@infra.apache.org > > Hi All, > > It seems the discussions tab has been removed for projects that had it > manually enabled but haven't changed their asf.yaml yet. Or at least that is > what has happend for us (apache/hop). Adding the feature discussions: true > resolved the issue. > > Kr, > Hans > On 13 Mar 2025 at 11:10 +0100, Jarek Potiuk <ja...@potiuk.com>, wrote: >> UPDATE! >> >> It looks that in some cases (combination of several factors, but resulting >> from different handling of old and new parser, when you had >> "required_review_count" set before, they might get disabled with the new >> parser on error and not restored properly. I have some "bandaid" fix >> https://github.com/apache/infrastructure-asfyaml/pull/26, but unless someone >> has similar urgent problem, it is better to revert to prevgen parser >> temporarily. This was not working but thanks to Thomas and Gavin we have it >> working now, You simply need to add this at the top of .asf.yml. >> meta: >> prevgen: true >> >> I think it will be better to wait for Daniel to get a "proper" fix rather >> than merge the bandaid. >> >> J. >> >> >> On Thu, Mar 13, 2025 at 8:50 AM Jarek Potiuk <ja...@potiuk.com >> <mailto:ja...@potiuk.com>> wrote: >>> I hope it's limited, but in case other repos have the same problem with >>> branch protection. >>> >>> I think it would be good if everyone just syncs/pulls their repo now and >>> then later review (after branch protection is fixed) merged commits since >>> to see it they were all legitimately reviewed and approved - otherwise we >>> might risk some bad changes sneaking in. >>> >>> J. >>> >>> >>> On Thu, Mar 13, 2025 at 8:45 AM Jarek Potiuk <ja...@potiuk.com >>> <mailto:ja...@potiuk.com>> wrote: >>>> I think there is a serious teething problems with the new .asf.yaml - > >>>> branch protection is gone for https://github.com/apache/airflow and we >>>> lost the discussions tab for example, I am afraid others might be in the >>>> same (bad) place. >>>> >>>> On Thu, Mar 13, 2025 at 8:26 AM Jacques Le Roux >>>> <jacques.le.r...@les7arts.com <mailto:jacques.le.r...@les7arts.com>> wrote: >>>>> Le 12/03/2025 à 15:21, Daniel Gruno a écrit : >>>>> > On 3/12/25 04:56, Jacques Le Roux wrote: >>>>> >> Le 12/03/2025 à 10:16, Martin Grigorov a écrit : >>>>> >>> >>>>> >>> >>>>> >>> On Wed, Mar 12, 2025 at 11:03 AM Jacques Le Roux >>>>> >>> <jacques.le.r...@les7arts.com <mailto:jacques.le.r...@les7arts.com>> >>>>> >>> wrote: >>>>> >>> >>>>> >>> Le 11/03/2025 à 23:13, Daniel Gruno a écrit : >>>>> >>> > Custom messages can be configured for squash and merge commits >>>>> >>> Hi Daniel, >>>>> >>> >>>>> >>> How that's done? I could not find it at https://github.com/apache/ >>>>> >>> infrastructure-asfyaml >>>>> >>> >>>>> >>> >>>>> >>> https://github.com/apache/infrastructure-asfyaml/tree/ng-parser? >>>>> >>> tab=readme-ov-file#merge-buttons >>>>> >> >>>>> >> Thanks Martin! >>>>> >> >>>>> >> >>>>> > Sorry about that, Jacques, the ng-parser branch was supposed to have >>>>> > been merged into main here, but that hasn't happened yet. I'll prod my >>>>> > colleagues today. >>>>> >>>>> No worries Daniel, I did not push yet. >>>>> >>>>> Jacques >>>>>
