Laszlo (Laca) Peter wrote:
>> %description
>> Backwards compatibility links for old paths under /usr/openwin for
>> XScreenSaver
>> files.
> 
> The descriptions (although not currently used for either SVr4 or
> IPS packages), should be linked to the packages:
> 
> %description -n SUNWxwsvr

Fixed.   I'd copied the descriptions out of our SVR4 packages, and
wondered why it seemed they weren't being used.

> The other comment is that we generally prefer -p1 patches, but
> I realise it's a pain to convert 45 patches...

Actually that's not bad - I tweaked the regen-patches rule from our
Makefiles that I use to update patches to apply cleanly to new
upstream releases to strip one less level off the filenames and let
it run.   It's a far cry from the speed & flexibility of "git
rebase --interactive", but it worked for this.

I'll post an updated spec & patch set once I've tested them.

-- 
        -Alan Coopersmith-           alan.coopersmith at sun.com
         Sun Microsystems, Inc. - X Window System Engineering


Reply via email to