Jedy:

> Do you mean the restart/shutdown option in login window. If so, they
> depends on the privilege of "gdm" user. But my patch is for
> gnome-session and only affects restart/shutdown button on reboot dialog.
> In most cases, gnome-session is run by "console user". So it should have
> enough privilege to restart/shutdown the system.

You didn't answer my question about whether you tested this.  ConsoleKit
currently has this code:

             !chkauthattr (RBAC_SHUTDOWN_KEY, username)) {

Note that RBAC_SHUTDOWN_KEY corresponds to solaris.system.shutdown.

So, if gnome-session passes in the correct username, and if that
username has the authorization to solaris.system.shutdown, then I'd
think it should work.

I just think you should test it before changing the patch.  If it works,
then there is no harm in removing the
gnome-session-07-logout-dialog.diff patch.

Brian


> But anyway, because consolekit and new gdm is targeting b128. So I will
> back out my patch first and integrate it at b128 or later.
> 
> Regards,
> 
> Jedy
> On Tue, 2009-07-28 at 15:34 -0500, Brian Cameron wrote:
>> Jedy:
>>
>>  > Because new gdm and consolekit have been integrated into vermillion. I
>>  > updated the 07-logout-dialog.diff. Now the logout dialog does not
>>  > depends on gnome-power-manager to restart/shutdown the system.
>>
>> Have you actually tested to make sure this works?  Note that the
>> ConsoleKit code talks directly to RBAC and only makes the
>> shutdown/reboot options available if the "gdm" user has
>> the solaris.system.shutdown authority defined.
>>
>> So, I would expect this not to work as you expect unless ConsoleKit on
>> Solaris is enhanced to work the same way that GNOME Power Manager does.
>>
>> Since GNOME Power Manager talks to PolicyKit while GDM on Solaris
>> does not, it might be easier to continue using the Power Manager
>> interfaces on Solaris.
>>
>> What do you think?
>>
>> Brian
>>
> 
> 


Reply via email to