Takao: >> I don't think the SUNWdtlogin-integration package is a good place >> to install GDM-specific startup scripts. The SUNWdtlogin-integration >> package is instead for CDE specific integration files. > > If you look at the spec file, I added SUNWdesktop-startup package newly in > SUNWdtlogin-integration.spec.
I'd think it would be better to create separate spec files for each package. Building different packages via %if statements in the same spec-file seems really confusing to me. > /usr/dt/config/Xsession.d is added to SUNWgnome-dtlogin-integration package. > /etc/X11/xinit/xinitrc.d and dtstart are added to SUNWdesktop-startup package. > > Does it make sense? Yes, and it looks correct. If your plan is to modify the CDE startup scripts to move some logic from /usr/dt/config/Xinitrc.jds to /usr/dt/config/Xsession.d scripts, then that is an okay change to make. It does clean things up I think. However, we should probably not focus too much time on improving the CDE login scripts since they are going away. >> Since /etc/X11/xinit/xinitrc.d is supposed to be a display-manager >> neutral directory, it might make sense to install these scripts (and the >> dtstart script) via a new package. Perhaps SUNWxinitrc-scripts or >> something would be a good neutral name. >> >> I guess I don't understand the need for the >> SUNWgnome-dtlogin-integration-01-migration.diff patch. Why are we >> changing how CDE login integration works at all? > > Now the scripts are moved into /usr/dt/config/Xsession.d. > So SUNWgnome-dtlogin-integration has the duplicated part. This patch removes > the duplicated part. Okay, I understand now. Looking back over your diff, what you are proposing for the /usr/dt/config/Xsession.d directory looks wrong to me. Note that /usr/dt/config/Xsession.d already contains the following scripts and these scripts are owned by the CDE project, not the GNOME project: 0005.dbus 0010.dtpaths 0015.sun.env 0020.dtims 0030.dttmpdir 0040.xmbind 1099.br Doesn't your new 0010.env script conflict with the existing 0010.dtpaths script. Why do both use the same 0010 number? Likewise your 0020.dtims conflicts with the script of the same name shipped with CDE? Ditto for 0030.dttmpdir, 0040.xmbind, and 1099.br scripts. If you want to change these scripts you should probably be coordinating with the CDE team to replace them with your improved scripts. Trying to add them in the SUNWdtlogin-integration package is the wrong place. As I said before, it might be best to just not make any changes to /usr/dt/config/Xsession.d and let it just go away when CDE login is EOL'ed and removed. If you want to make some cleanup in SUNWdtlogin-integration, then it is probably okay if you add new scripts to /usr/dt/config/Xsession.d to add anything that is missing. For example, if you want to move some logic from the Xinitrc.jds script to a new /usr/dt/config/Xsession.d script. But doing any coordination with the CDE team to replace the scripts owned by the CDE team would not be worth the work, I think. What do you think? >> Also, I would expect that the default /etc/gdm/Xsession script >> would need to be modified in conjunction with this change. I believe >> some of the code in the /etc/gdm/Xsession script has now been moved >> to /etc/X11/xinit/xinitrc.d. No? So I'm surprised to not see another >> patch to remove the code from /etc/gdm/Xsession that is no longer >> needed. > > Yes, I'll try to modify /etc/gdm/Xsession. > Since several parts are modified, I'd wanted the feedback before we'll modify > GDM. Seems reasonable. Brian
