On Mon, 2009-02-09 at 09:44 +0000, Niall Power wrote: > Hi Laca, > > Laszlo (Laca) Peter wrote: > > Do you guys have a code review process in place for the code itself? > > Bumping the tarball version doesn't tell much about the code changes. > > > > I included the diffs for the actual code changes in the review mail > I sent out..
Ah, sorry... there was some noise at the end of the diff and I scrolled through too quickly... > But presumably bumping the tarball is preferable to accumulating > patches in spec-files-other? Depends. For tiny changes it may be better to add a patch and fix the same thing in svn/hg. Ask Stephen :) BTW, now that I found the diff: +PYTHON = /usr/bin/python Please use a versioned python interpreter, i.e. /usr/bin/python2.4 Even better, make it configurable so we only need to change the spec file when we switch from 2.4 to 2.6. Laca
