Hi Ke,
On Mon, 2009-02-09 at 17:50 +0800, Ke Wang wrote:
> #
> # spec file for package SUNWlibproxy.spec
Nit: please delete ".spec", the name of the package is SUNWlibproxy
> # includes module: libproxy
> #
> # Copyright (c) 2009 Sun Microsystems, Inc.
Another nit ;) please delete the (c) it's old style.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Owner: Ke Wang
This should be your opensolaris.org user name.
> %include Solaris.inc
>
> %ifarch amd64 sparcv9
> %include arch64.inc
> %use libproxy_64 = libproxy.spec
> %endif
>
> %include base.inc
> %use libproxy = libproxy.spec
>
> Name: SUNWlibproxy
> Summary: Libproxy is a library that provides automatic
> proxy configuration management
> Version: 0.2.3
Since you're using a base spec, this should refer to the version in the
base spec so that they don't become inconsistent:
Version: %{libproxy.version}
> Source1: %{name}-manpages-0.1.tar.gz
> SUNW_BaseDir: %{_basedir}
> SUNW_Copyright: %{name}.copyright
> BuildRoot: %{_tmppath}/%{name}-%{version}-build
>
> %include default-depend.inc
> Requires: SUNWgnome-config
> Requires: SUNWxwplt
> Requires: SUNWfirefox
> BuildRequires: SUNWgnome-config
Should probably be SUNWgnome-config-devel
> BuildRequires: SUNWxwplt
> BuildRequires: SUNWfirefox
and SUNWfirefox-devel
> %files
> %defattr (-, root, root)
Use root:bin for defattr.
> %ifarch amd64 sparcv9
> %{_libdir}/%{_arch64}/*.so.*
> %{_libdir}/%{_arch64}/*.so
> %{_libdir}/%{_arch64}/libproxy/*
> %endif
>
> %doc -d %{base_arch} libproxy-%{libproxy.version}/AUTHORS
> %doc -d %{base_arch} libproxy-%{libproxy.version}/COPYING
> %doc -d %{base_arch} libproxy-%{libproxy.version}/ChangeLog
> %doc -d %{base_arch} libproxy-%{libproxy.version}/NEWS
> %doc -d %{base_arch} libproxy-%{libproxy.version}/README
> %{_mandir}/man3/*
> %{_libdir}/*.so.*
> %{_libdir}/*.so
> %{_libdir}/libproxy/*
> %{_libdir}/python*
You will also need to specify the permissions of directories like
%{_libdir} amdn %{_datadir} that don't match defattr. E.g.:
%dir %attr (0755, root, sys) %{_datadir}
> %files devel
> %defattr (-, root, root)
> %{_libdir}/pkgconfig/*.pc
> %{_includedir}/libproxy/*
> %{_prefix}/demo/*
same comments as for %files
> %ifarch amd64 sparcv9
> %{_libdir}/%{_arch64}/pkgconfig/*.pc
> %endif
>
> %changelog
> * Mon Feb 9, 2009 - ke.wang at sun.com
> - Initial spec.
>
>
>
>
>
>
>
> RPM spec file
> attachment
> (libproxy.spec)
>
> #
> # spec file for package libproxy
> #
> # Copyright (c) 2009 Sun Microsystems, Inc.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Owner: Ke Wang
> #
Same comments for (c) and Owner as in SUNWlibproxy.spec
> %define pythonver 2.4
You should probably use Python 2.6
> # spec file for package libproxy
> #
> # Copyright (c) 2009 Sun Microsystems, Inc.
> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # Owner: Ke Wang
> #
You have this heading twice.
> %define pythonver 2.4
pythonver is redefined.
> %define _demodir `echo %{_bindir} | sed -e 's,%{_prefix},
> %{_prefix}/demo/jds,'`
use %(foo) for command substitution.
> Name: libproxy
> License: LGPL v2.1
> Group: System/Libraries/GNOME
> Version: 0.2.3
> Release: 1
> URL: http://code.google.com/p/libproxy/
> Distribution: Java Desktop System
> Vendor: Sun Microsystems, Inc.
> Summary: Libproxy is a library that provides automatic proxy
> configuration management
> Source:
> http://libproxy.googlecode.com/files/libproxy-%{version}.tar.gz
> #owner:wangke date:2009-02-02 type:bug
> Patch1: libproxy-01-orig-build.diff
Please also submit the patch for review.
I didn't review the man page.
Laca
