Attached please find the revised patch. And it is submitted to the community: http://bugzilla.gnome.org/show_bug.cgi?id=580070
Best Regards, Harry on 2009?04?23? 19:35, Takao Fujiwara - Tokyo S/W Center wrote: > The returned value should be freed and it's better to upstream the patch. > > FU Ning-san wrote (04/23/09 07:11 PM): >> Hi, all: >> >> Please review the patch for doo #8286(garbage displayed when adding >> folder to file-roller). >> >> Best Regards, >> Harry >> --- >> SUNWgnome-archive-mgr-2.26.1/file-roller-2.26.1/src/dlg-add-folder.c.orig >> >> 2009-04-23 03:00:46.000000000 +0800 >> +++ SUNWgnome-archive-mgr-2.26.1/file-roller-2.26.1/src/dlg-add-folder.c >> 2009-04-23 17:55:40.095363000 +0800 >> @@ -154,7 +154,7 @@ >> exclude_folders = NULL; >> >> dest_dir = build_uri (fr_window_get_current_location (window), >> - file_name_from_path (selected_folder), >> + file_name_from_path >> (g_filename_from_uri (selected_folder,NULL,NULL)), >> NULL); >> >> fr_window_archive_add_with_wildcard (window, >> >> =================================================================== >> --- file-roller.spec (revision 18178) >> +++ file-roller.spec (working copy) >> @@ -24,6 +24,8 @@ >> %endif >> # date:2003-07-24 type:branding owner:gman >> Patch1: file-roller-01-menu-entry.diff >> +# date:2009-04-23 type:bug doo #8286 owner:harry.fu at sun.com >> +Patch2: file-roller-02-add-folder.diff >> URL: http://www.gnome.org >> BuildRoot: %{_tmppath}/%{name}-%{version}-build >> Docdir: %{_defaultdocdir} >> @@ -65,6 +67,7 @@ >> cd po-sun; make; cd .. >> %endif >> %patch1 -p1 >> +%patch2 -p2 >> for po in po/*.po; do >> dos2unix -ascii $po $po >> done >> >> > -------------- next part -------------- A non-text attachment was scrubbed... Name: file-roller-02-add-folder.diff Type: text/x-patch Size: 951 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20090424/86934a3e/attachment.bin>
