Hi Laca,
Thanks for that feedback. Comments below...
Laszlo (Laca) Peter wrote:
>
> 2008, no (c)
>
Done.
>> # Owner: Darren, Lin
>
> This should be one opensolaris user name.
>
Changed to "dkenny"
>> Release: 0.5.0
>
> We don't use the Release field, but 0.5.0 is clearly wrong, should
> be 1 in the initial spec file, but you can also delete it.
Deleted.
>
>> Distribution: Java Desktop System
>> Vendor: Sun Microsystems, Inc.
>
> You can delete these, they are set in Solaris.inc
Deleted.
>> #Source1: %{name}-po-sun-%{po_sun_version}.tar.bz2
>
> Will the l10n bits be added later?
They should be eventually, right now we don't have any translations, this is
just a place holder until they are available.
>> URL: http://www.opensolaris.org
>
> A link pointing directly to NWAM would be nicer.
Change it to point to the nwam project.
>
>> %if %build_l10n
>> %endif
>
> Should be deleted?
Deleted.
>> #error when parallel make
>> #make -j $CPUS
>
> It would be nice to find the missing dependencies in the Makefiles.
>
Hmm, I think this was old, I removed it and the build worked fine on my 2CPU
machine.
>> (SUNWnwam-manager.spec)
>> # Owner: Darren, Lin
>
> Same comment for the owner as in the base spec.
Changed to dkenny
>> Summary: Nwam
>
> This becomes the one-line description of the package which is
> displayed by pkginfo and shown in the package manager so please
> put something more descriptive here.
Changed to "Network Auto-Magic User Interface"
>
>> export CFLAGS="%optflags"
>
> Hmm... the %build section in the base spec resets
> CFLAGS to $RPM_OPT_FLAGS (which is the same as %optflags).
> So you should only need one of these.
Yep, you're right, removed it here and changed base-spec to use %optflags.
>
>> export LDFLAGS="%_ldflags"
>
>> export ACLOCAL_FLAGS="-I %{_datadir}/aclocal"
>
> This shouldn't be needed.
>
Removed.
>> %nwam_manager.build -d %name-%version
>>
>> export PKG_CONFIG_PATH=../nwam-manager-%{nwam-manager.version}
>
> This is definitely not needed, since it's the end of the script.
>
Yep, removed.
>
>> %attr (-, root, other) %{_datadir}/nwam-manager/*.*
>> %attr (-, root, other) %{_datadir}/nwam-manager/icons/*
>
> Why are these root:other?
Changed them to root,bin to match their directories, but I probably was just
copying the /usr/share/icons permissions when I shouldn't be.
>
>> %{_sysconfdir}/gconf/schemas/nwam-manager.schemas
>
> You need a %preun root script that uninstalls this schema.
>
Added one.
Thanks,
Darren.
