Hi Evan,
Thanks for the review.
Evan Yan wrote:
> Hi Alfred,
>
>
>> +%if %without_moz_nss_nspr
>> +# owner:davelam date:2006-01-13 type:branding
>> +# let Songbird use system bundled nss,nspr
>>
>
> You forgot to change the owner and date
>
I just copy the patch from Firefox and didn't change it. Should I update
the owner and date?
>> +%if %without_moz_nss_nspr
>> +Requires: SUNWpr
>>
>> +#FIXME: remove this after the system nss/nspr libraries are upgraded.
>> +Requires: SUNWfirefox
>> +%endif
>>
>
> I guess you mean
> %else
> Requires: SUNWfirefox
>
"without_moz_nss_nspr" means to use the system nss/nspr. Before they are
upgraded to the minimal requirement, Songbird will depend on Firefox's.
>
>> +%if %without_moz_nss_nspr
>> +LDFLAGS="$LDFLAGS -R%{_libdir}/firefox"
>> +%endif
>> +export LDFLAGS
>>
>
> %else is also missed here.
>
This part will be updated to "-R%{_libdir}/mps" when the system
libraries are upgraded.
Thanks,
-Alfred
> -Evan
>
>
> Alfred Peng wrote:
>
>> Hi guys,
>>
>> One of the ARC opinions for Songbird is to make it to depend on
>> Firefox's nss/nspr for now. When the system nss/nspr are upgraded to the
>> minimal requirement, Songbird will depend on the system ones.
>>
>> Attached are the patches to address this issue which derives from
>> Firefox's spec.
>>
>> Thanks,
>> -Alfred
>>
>>
