Hi Halton,
Thanks for the comments. My responses are in-line ...
Halton Huo wrote:
> Niall,
>
> Please see comments in-lines.
>
>
>> Name: SUNWzfs-auto-snapshot
>> Summary: ZFS automatic snapshot service
>> Version: 0.11.0
>> Source: zfs-snapshot.tar.bz2
>>
> Is there any world wide link which is available for external users?
>
No not at the moment. There's Tim's blog ? :-)
>
>> SUNW_BaseDir: /
>>
> Suggest use macros in Solaris.inc, here is
> SUNW_BaseDir: %{_basedir}
>
%{_basedir} evaluates to /usr so I can't use it, as the basedir needs
to be "/" as the pkg needs to install SMF services to /var/svc/manifest
and /lib/svc/method.
>
>> %include default-depend.inc
>>
> No other dependencies? I guess SUNWzfsu should be in.
>
Good point. I'll add it. There's nothing else special required
since it's just a bunch of shell scripts and an SMF manfiest so
the cores system should be sufficient.
>
>> mkdir -p $RPM_BUILD_ROOT/etc/security
>> echo 'solaris.smf.manage.zfs-auto-snapshot:::Manage the ZFS Automatic
>> Snapshot Service::' > $RPM_BUILD_ROOT/etc/security/auth_attr
>>
> Same as #1 comment, use {_sysconfdir} for /etc
>
I don't think that is an appropriate use of %{_sysconfdir} in this case.
That macro's purpose is to allow
the software package and it's installed contents to be relocatable.
/etc/security/auth_attr does not belong
to this package and neither is /etc/security/auth_attr relocatable. If
the package was to be installed under
/usr/local for example then using %{_sysconfdir} would result in the
auth_attr file being located at
/usr/local/etc/security/auth_attr. This would break the package and
other NS lookups for the role.
>
>> %files
>> %defattr (-, root, bin)
>> %dir %attr (0755, root, sys) /var
>> %dir %attr (0755, root, sys) /var/svc
>> %dir %attr (0755, root, sys) /var/svc/manifest
>> %dir %attr (0755, root, sys) /var/svc/manifest/system
>> %dir %attr (0755, root, sys) /var/svc/manifest/system/filesystem
>> %class(manifest) %attr (0444, root, sys)
>> /var/svc/manifest/system/filesystem/*.xml
>> %dir %attr (0755, root, bin) /lib/svc/method
>> %attr (0555, root, bin) /lib/svc/method/zfs-auto-snapshot
>> %dir %attr (0755, root, sys) /etc
>> %dir %attr (0755, root, sys) /etc/security
>> %config %class (rbac) %attr (0644, root, sys) /etc/security/auth_attr
>>
> Same as #1 comment, use {_sysconfdir} for /etc
>
Same as my #1 response :)
> Like SUNWtime-slider.spec, shall files under /etc
> and /var/svc/manifest/system/filesystem/*.xml be separated into -root
> package?
Not in this case because the only directories we deliver files into
or modify are:
/etc
/var
/lib
These all fall under the mapping of a "-root" filesystem package. There
would
be nothing to install in a seperated "/usr" package so we don't need to
split
the package up and just use the basename for the package name
>
> Laca, any comment?
>
>
>> Name: SUNWgnome-time-slider
>> Summary: Time Slider ZFS snapshot management for GNOME
>> Version: 0.1.0
>> Source: time-slider.tar.bz2
>>
> Same as above
>
No external website right now. Just a mercurial repository on
opensolaris.org
>
>> %files
>> %defattr (-, root, bin)
>> %{_bindir}/*
>> %dir %attr (0755, root, bin) %{_libdir}
>> %{_libdir}/time-slider-*
>> %dir %attr (0755, root, sys) %{_datadir}
>> %dir %attr (0755, root, other) %{_datadir}/applications
>> %{_datadir}/applications/time-slider-*.desktop
>> %{_datadir}/icons/hicolor/*/apps/time-slider-setup.png
>>
> You may meet attr conflict when install this package.
> should be root:other for /usr/share/icons/hicolor/*
> and /usr/share/icons/hicolor/*/apps.
>
Good catch. I added the icons in a hurry this morning and forgot
this detail.
I've updated the spec files and attached them.
Thanks,
Niall.
> You can refer SUNWgnome-session.spec
>
>
> -Halton.
>
>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SUNWzfs-auto-snapshot.spec
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080917/c4c145d4/attachment.ksh>
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: SUNWgnome-time-slider.spec
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080917/c4c145d4/attachment-0001.ksh>
