Hi Kevin, Totally the spec is fine, there are some comments for you, please check in lines.
> Source: http://releases.0x539.de/obby/obby-%{version}.tar.gz > Patch1: obby-01-cast.diff Please add comment for this patch. > %files > %doc COPYING AUTHORS NEWS ChangeLog README > > COPYING: GNU GPL > AUTHORS: list of authors of obby > NEWS: list of the most important changes in obby > ChangeLog: list of all changes and authors of obby > README: more information about obby COPYING/NEWS/ChangeLog are normally big files, please use .bz2 format. Save as comment #2. $wc -l COPYING AUTHORS NEWS ChangeLog README 351 COPYING 30 AUTHORS 71 NEWS 2417 ChangeLog 14 README For obby, COPYING and ChangeLog should use .bz2 > Source: http://releases.0x539.de/gobby/gobby-%{version}.tar.gz > Patch1: gobby-01-prototype.diff > Patch2: gobby-02-const.diff > Patch3: gobby-03-auto_ptr.diff Same as comment #1. > autoconf Only autoconf need here? How about aclocal, autoheader, automake? > > CXXFLAGS="-xO2" Not sure this is right when use --with-debug option. > > %post > ( echo 'test -x /usr/bin/update-desktop-database || exit 0'; > echo '/usr/bin/update-desktop-database' > ) | $BASEDIR/lib/postrun -b -u -c JDS_wait Please use %include desktop-database-install.script instead > > %postun > test -x $BASEDIR/lib/postrun || exit 0 > ( echo 'test -x /usr/bin/update-desktop-database || exit 0'; > echo '/usr/bin/update-desktop-database' > ) | $BASEDIR/lib/postrun -b -u -c JDS Please use %include desktop-database-uninstall.script instead > > %files > %doc COPYING AUTHORS NEWS ChangeLog README > %dir %attr (0755, root, other) %{_datadir}/doc > COPYING: GNU GPL > AUTHORS: list of authors of gobby > NEWS: list of the most important changes in gobby > ChangeLog: list of all changes and authors of gobby > README: more information about gobby For gobby, COPYING, NEWS, ChangeLog and README need use .bz2 $wc -l COPYING AUTHORS NEWS ChangeLog README 340 COPYING 40 AUTHORS 133 NEWS 2717 ChangeLog 129 README 3359 total -Halton
