Ghee: >> Looking at the dbus-launch code I see that when you use "-auto-syntax" >> that all this does is check the users SHELL variable and determine >> whether to use csh or sh syntax based on that variable. A better fix >> seems to be to not use this argument and instead use --sh-syntax if you >> want to force dbus-launch to run with sh syntax. >> >> Why not fix the problem this way? This seems more straightforward. > I am. I used --auto-syntax in my initial fix. Now, I use --sh-syntax.
When using --sh-syntax, I don't understand the need to patch the code to save the user's SHELL, hack SHELL to ksh, and then reset it after calling dbus-launch. This should only be a needed if --auto-syntax is used. No? Also, why are we patching dtlogin-integration rather than putting the changes directly into the dtlogin-integration module and respinning a new release? Brian
