I reworked the patch. In the new patch, just removing the files corresponding the 2 plugins from the spec-file as the maintainer suggested. Please review.
Thanks - Jerry Brian Cameron wrote: > > Jerry: > >> totem enables youtube and gromit plugins by default without checking >> the dependencies required. The patch is to fix this problem. At first >> it will check if the necessary dependencies by gromit and youtube >> plugins were installed, if not, these two pluings will be disabled. > > Note that this patch was rejected by the upstream maintainer (see > bugzilla #530612), and the maintainer doesn't seem willing to accept a > patch upstream to fix this issue. He seems to be of the opinion that > since the dependencies are only runtime dependencies that it is okay > to build and install the plugins even if they don't work since end > users can later install the dependencies. He recommends that if we > really want to remove them, to remove them via "rm" in spec-files. > > Based on this, I do not think it makes sense to fix this issue via a > patch since the fix won't get upstream anyway. I think we should > follow the maintainers advise and just remove these plugins by > adding "rm" statements to the spec-file. We should probably add a > comment highlighting why we are removing them as well (in other words > explain what dependencies are missing that are causing us to remove > them). > > Brian -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080508/434faab9/attachment.ksh>
