Can you provide the diff of diff? I think it's good to review a minor fix. BTW, DocumentDirectory doesn't seem to be freed, though it may not cause any big issues.
lin C Wang wrote: > Forgot to mention, the only change compare to the original patch > nautilus-09 is in nautilus-desktop-link.c, I regenerated the whole patch > to avoid apply the patch on patch. > > Chris > > > > ------------------------------------------------------------------------ > > Subject: > Please review the patch to fix bug 6663349 restarting nautilus > generates garbage in $HOME > From: > C Wang <Chris.Wang at Sun.COM> > Date: > Thu, 20 Mar 2008 19:13:19 +0800 > To: > jds-review at opensolaris.org > > To: > jds-review at opensolaris.org > > > Please review the patch fixed bugster bug 6663349 restarting nautilus > generates garbage in $HOME. > > This is a regression of patch nautilus-09, the return type of > g_file_new_for_path is a GFile *, not gchar* > > In the original patch, we used g_file_test to testing whether the > certain directory is exist, then create it if not present, but the > parameter we passed into g_file_test is a GFile, thus, some strange > string will be generated and the garbage directory is created in $HOME. > > To fix the bug, we simply use a separate gchar* to store the user's > document directory. > > Chris > > -- x82120 / +86 10 82618200
