Laca,

Thanks for your reviewing.

I'm trying to persuade them not use "-O0" when have "-g". If they do not
think it is right way, I'll use your suggestion to remake the patch.

-Halton. 

On Wed, 2008-07-09 at 00:19 +1200, Laszlo (Laca) Peter wrote:
> Halton,
> 
> I think this should be upstreamable.  You may want to make
> this change conditional to the compiler used, something like
> if [ "x$GCC" = xyes ]; then
>       <set the original flags>
> else
>       <don't set -O0>
> fi
> 
> Laca
> 
> On Tue, 2008-07-08 at 14:06 +0800, Halton Huo wrote:
> > Hi,
> > 
> > -O0 is not recognied in ss11, this will break tsclient build with
> > "--enable-debug=yes". Since "-O0" is useless when have "-g", so I'd like
> > to remove "-O0" in this patch.
> > 
> > Thanks,
> > Halton.
> 


Reply via email to