Alfred: Shouldn't the two patches go upstream? Even if Songbird wants to support non-GNOME applications, I'd think the configure script could still detect if there is a /usr/share/applications directory and add the desktop file if so.
Also, shouldn't this have Requies and BuildRequires on SUNWgnome-media since it depends on GStreamer? > Please help me review the spec file for Songbird. SUNWsongbird.spec will > be in spec-files-other/core. > %if %with_debug > %define build_type debug > %else > %define build_type release > %endif > > %ifarch sparc > %define arch sparc > %else > %define arch i386 > %endif That seems odd to me. Shouldn't this kind of stuff be handled by the Solaris.inc include? > Summary: The desktop media player mashed-up with the Web. "mashed-up with the Web" doesn't make sense to me. > Version: 0.6 > %define tarball_version 0.6.1 Why not just define Version to be 0.6.1 and avoid using tarball_version? > Songbird provides a public playground for Web media mash-ups by I'm not sure what "public playground" means. > providing developers with both desktop and Web APIs, developer > resources and fostering Open Web media standards. This description doesn't seem to do a great job of explaining that this is a media player. > ac_add_options --disable-dtrace > ac_add_options --disable-dbus Why don't we want dtrace and D-Bus support? Brian
