Brian:
Brian Cameron ??: > > Chris: > >> Per suggested by Brian, the default editor can be configured during >> configuration. > > It seems the old command has a "-n" option, but this seems lost in the > patch. If the "-n" option should be used in some situations but not > others, shouldn't this also be detected in the configure and managed > via "#ifdef"? Did you report this patch upstream? > There has no -n option in current version of gimp-remote http://www.gimp.org/man/gimp-remote.html I think we can safely remove the -n here. I will report a bug for this. Thanks Chris > Brian > > - N_("The Gimp"), "gimp-remote -n %f", > +#ifdef EDITOR_GIMP > + N_("The Gimp"), "gimp-remote %f", > +#else > > >> Chris >> >> Brian Cameron ??: >>> >>> Laca: >>> >>>> Wouldn't it be a better fix to only include these apps in the >>>> menu if they are found in the PATH? So if someone installs >>>> xv or xpaint they will see it in the menu others won't? >>>> Such a change would probably be acceptable upstream. >>> >>> Another option might be to check for the programs during configure >>> and disable support for them if not found. Though, I think checking >>> at runtime, as Laca suggests, makes more sense. That way it will work >>> if the user installs a program like xpaint themselves without needing >>> to recompile gqview. >>> >>> Brian >>> >>> >>>> On Mon, 2008-07-07 at 16:34 +0800, C Wang wrote: >>>>> gqview can invoke external editor to edit the image it display, >>>>> gimp, xv >>>>> and xpaint are the default optional applications it can invoke. We >>>>> don't >>>>> ship xv and xpaint by default. This patch removes these two options. >>>>> >>>>> Chris >>>>> >>>>> plain text document attachment (gqview-01-editor.diff) >>>>> --- gqview-2.0.4/src/editors.c.orig 2008-07-07 16:20:41.728472000 >>>>> +0800 >>>>> +++ gqview-2.0.4/src/editors.c 2008-07-07 16:22:26.304812000 +0800 >>>>> @@ -47,9 +47,9 @@ >>>>> >>>>> >>>>> static gchar *editor_slot_defaults[] = { >>>>> - N_("The Gimp"), "gimp-remote -n %f", >>>>> - N_("XV"), "xv %f", >>>>> - N_("Xpaint"), "xpaint %f", >>>>> + N_("The Gimp"), "gimp-remote %f", >>>>> + NULL, NULL, >>>>> + NULL, NULL, >>>>> NULL, NULL, >>>>> NULL, NULL, >>>>> NULL, NULL, >>>> >>> >> >
