On Jan 14, 2008 10:02 PM, Brian Cameron <Brian.Cameron at sun.com> wrote:
>
> Patrick:
Hello Brian!
>
> First of all, we normally do not patch Makefile.in files. Instead we
> patch Makefile.am, and the Makefile.in file should get built via running
> automake then configure.
The problem with this is that I didn't find any references to the 'if'
tests done in the Makefile.in or the install-xmlDATA stage where
things go wrong. Patching Makefile.am was really just intended to root
cause the problem and provided to you (the list) for testing purposes
:)
>
> It seems the old GOK installed the kbd files directly to /usr/share/gok
> and not /usr/share/gok/C. Is the fact that these files moved (or are
> perhaps gettings installed to two locations) an artifact of your patch?
This seems to be new behaviour. Actually this is where the whole
problem started. 'make install' creates the *.kbd files in the locale
directories and not in $(srcdir) . Later on though it tries to
$(install_xmlDATA $$d/$$p $(DESTDIR/${xmldir) and for some reason ends
up with trying to copy *.kbd files from $(srcdir). So what I tried to
do (and what my patch was about) is to work around the attempt to
install ./mouse.kdb. (Which is why I made the 'if [ $$d == "" ]'. the
$$d represents the locale directory, if I read it correctly of course.
>
> Above, you remove the line which sets variable %d, so it does not seem
> to make sense to check the variable $$d here. Or am I missing
> something?
Not at all, actually Damien mailed me and Laca off the list about
this. He tried my patch and mentioned he added two lines to initialise
the variables. This was my bad.
>
> Why do we need the 2nd for loop. What aren't the *xam files just
> included in xml_DATA?
This is because the xam files are weirdly enough not in the locale
subdirectories but in $(srcdir). I looked what the behaviour of
logging was for the install part, saw a seperate 'echo' was done
notify which file was being installed, and I tried to make the same
behaviour.
As a further note: I tried to build the package on it's own, a simple
./configure --prefix=/tmp/bla && make && make install. And I come to
the same errors, ./mouse.kbd not found. So this really seems to be an
issue with the build process.
>
> Brian
Patrick / WickedWicky
