Ouch, separate emails would have been better, but
here it goes:

On Thu, 2008-02-14 at 17:57 +0000, Dermot McCluskey wrote:
> #
> # spec file for package SUNWdcraw
> #
> # Owner: bnitz
> #

Please add the usual copyright notice.

> %include Solaris.inc
> 
> Name:                    SUNWdcraw
> Summary:                 dcraw - Decoding RAW digital photos in Linux
> URL:                     http://www.cybercom.net/~dcoffin/dcraw/
> Version:                 8.81
> Source:
> http://cybercom.net/~dcoffin/dcraw/archive/dcraw-%{version}.tar.gz
> SUNW_BaseDir:            %{_basedir}
> BuildRoot:               %{_tmppath}/%{name}-%{version}-build
> %include default-depend.inc
> 
> Requires:               SUNWlcms
> BuildRequires:          SUNWlcms

Is there a SUNWlcms-devel?

> 
> %prep
> %setup -q -c -n %{name}-%{version}
> 
> 
> %build
> cd dcraw
> # There's no Makefiles - it's just a single .c file
> cc -o dcraw dcraw.c -lm -ljpeg -llcms

Please use ${CC} and %optflags

> %install
> rm -rf $RPM_BUILD_ROOT
> mkdir $RPM_BUILD_ROOT
> mkdir -p $RPM_BUILD_ROOT%{_bindir}
> cd dcraw
> cp dcraw $RPM_BUILD_ROOT%{_bindir}
> 
> mkdir -p $RPM_BUILD_ROOT%{_mandir}/man1
> cp dcraw.1 $RPM_BUILD_ROOT%{_mandir}/man1
> 
> for lang in \
>         cs de eo es fr hu it nl pl pt ru zh_CN zh_TW
> do
>         mkdir -p -m 755 $RPM_BUILD_ROOT
> %{_datadir}/locale/$lang/LC_MESSAGES
>         msgfmt -o $RPM_BUILD_ROOT
> %{_datadir}/locale/$lang/LC_MESSAGES/dcraw.mo dcraw_$lang.po
> done

Only install the mo files %if %option_with_l10n.

> %clean
> rm -rf $RPM_BUILD_ROOT
> 
> 
> %files
> %defattr(-, root, bin)
> %dir %attr (0755, root, bin) %{_bindir}
> %{_bindir}/dcraw
> %dir %attr (0755, root, sys) %{_datadir}
> %dir %attr (0755, root, bin) %{_mandir}
> %dir %attr (0755, root, bin) %{_mandir}/man1
> %{_mandir}/man1/dcraw.1
> %defattr(-, root, other)
> %{_datadir}/locale/*

Create an l10n subpkg and put the contents of %{_datadir}/locale there.

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWid3lib.spec)
> 
> #
> # spec file for package SUNWid3lib
> #
> # Owner: christian
> #

Copyright header

> %include Solaris.inc
> 
> Name:                    SUNWid3lib
> Summary:                 id3lib  - a software library for manipulating
> ID3v1/v1.1 and ID3v2 tags
> Version:                 3.8.3
> Source:
> %{sf_download}/id3lib/id3lib-%{version}.tar.gz

We don't have sf_download defined.  It should be defined though.

> Patch1:                  id3lib-01-wall.diff
> Patch2:                  id3lib-02-uchar.diff

Patch comments please.

> SUNW_BaseDir:            %{_basedir}
> BuildRoot:               %{_tmppath}/%{name}-%{version}-build
> %include default-depend.inc
> Requires: SUNWzlib
> Requires: SUNWlibC
> Requires: SUNWlibms
> 
> %package devel
> Summary:                 %{summary} - development files
> SUNW_BaseDir:            %{_basedir}
> %include default-depend.inc
> Requires: %name
> 
> %prep
> %setup -q -n id3lib-%version
> %patch1  -p1
> %patch2  -p1
> 
> %build
> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '`
> if test "x$CPUS" = "x" -o $CPUS = 0; then
>     CPUS=1
> fi

> export ACLOCAL_FLAGS="-I %{_datadir}/aclocal"
> export MSGFMT="/usr/bin/msgfmt"

These are probably unnecessary.

> %ifarch sparc
> export CFLAGS="-xO5 -xlibmil"
> export CXXFLAGS="-norunpath -xO5 -xlibmil -xlibmopt -features=tmplife"
> %else
> export CFLAGS="-xO3 -xlibmil"
> export CXXFLAGS="-norunpath -xO3 -xlibmil -xlibmopt -features=tmplife"
> %endif

I'm wondering if these are really needed or were c&p'ed from
somewhere else.

If there is C++ code, please add the following magic lines:

%if %cc_is_gcc
%else
export CXX="${CXX} -norunpath"
%endif

> ./configure --prefix=%{_prefix} --mandir=%{_mandir} \
>             --libdir=%{_libdir}              \
>             --libexecdir=%{_libexecdir}      \
>             --sysconfdir=%{_sysconfdir}      \
>             --enable-fpm=%{fp_arch}          \

I don't see %fp_arch defined anywhere.

>             --enable-shared                  \
>             --disable-static
> 

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpysqlite.spec)
> 
> #
> # spec file for package SUNWpysqlite
> #
> # Owner: dkenny
> #

Copyright header.
Otherwise looks okay.
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-imaging.spec)
> 
> #
> # spec file for package SUNWpython-imaging
> #
> # Owner: dkenny
> #

Copyright header.
Otherwise looks okay.

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-mysql.spec)
> 
> #
> # spec file for package SUNWpython-mysql
> #
> # Owner: dkenny
> #

Same again.

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-setuptools.spec)
> 
> #
> # spec file for package SUNWpython-setuptools
> #
> # Owner: dkenny
> #

And again.

> %include Solaris.inc
> 
> %define oname setuptools
> %define name python-%oname
> %define version 0.6c7
> 
> Name:            SUNW%{name}
> Summary:         Download, build, install, upgrade, and uninstall
> Python packages easily
> URL:             http://peak.telecommunity.com/DevCenter/setuptools
> Version:         %{version}
> Source0:
> http://cheeseshop.python.org/packages/source/s/%{oname}/%{oname}-%{version}.tar.gz
> SUNW_BaseDir:    %{_basedir}
> BuildRoot:       %{_tmppath}/%{name}-%{version}-build
> BuildRequires:   SUNWPython-devel
> 
> %include default-depend.inc
> 
> %define pythonver 2.4
> 
> %prep
> %setup -q -n %oname-%version
> 
> %build
> python setup.py build
> perl -pi -e 's|^#!python|#!/usr/bin/python|' easy_install.py
> setuptools/command/easy_install.py
> 
> %install
> rm -rf $RPM_BUILD_ROOT
> python setup.py install --prefix=$RPM_BUILD_ROOT/%_prefix
> --old-and-unmanageable

What's this?  (Just curious...)

> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-twisted.spec)
> 
> #
> # spec file for package SUNWpython-twisted
> #
> # Owner: dkenny
> #

Copyright.

> %include Solaris.inc
> 
> %define name Twisted
> 
> Name:                    SUNWpython-twisted
> Summary:                 Event-based framework for internet
> applications
> URL:                     http://twistedmatrix.com/trac/
> Version:                 2.5.0
> Source:
> http://tmrc.mit.edu/mirror/twisted/Twisted/2.5/Twisted-%{version}.tar.bz2
> SUNW_BaseDir:            %{_basedir}
> BuildRoot:               %{_tmppath}/%{name}-%{version}-build
> Requires:                SUNWPython
> BuildRequires:           SUNWpython-zope-interface
> 
> %include default-depend.inc
> 
> %define pythonver 2.4
> 
> %prep
> %setup -q -n Twisted-%version
> 
> %build
> python setup.py build
> 
> %install
> rm -rf $RPM_BUILD_ROOT
> python setup.py install --prefix=$RPM_BUILD_ROOT/%_prefix
> 
> # move to vendor-packages
> mkdir -p $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/vendor-packages
> mv $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/site-packages/* \
>    $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/vendor-packages/
> rmdir $RPM_BUILD_ROOT%{_libdir}/python%{pythonver}/site-packages
> 
> %{?pkgbuild_postprocess: %pkgbuild_postprocess -v -c "%{version}:
> %{jds_version}:%{name}:$RPM_ARCH:%(date +%%Y-%%m-%%d):
> %{support_level}" $RPM_BUILD_ROOT}
> 
> %clean
> rm -rf $RPM_BUILD_ROOT
> 
> %files
> %defattr (-, root, bin)
> %dir %attr (0755, root, bin) %{_bindir}
> %{_bindir}/*
> %dir %attr (0755, root, bin) %{_libdir}
> %{_libdir}/python%{pythonver}/vendor-packages/twisted

Are there .pyo files to be deleted?
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-xdg.spec)
> 
> #
> # spec file for package SUNWpython-xdg
> #
> # Owner: dkenny
> #

copyright


> %files
> %defattr (-, root, bin)
> %dir %attr (0755, root, bin) %{_libdir}
> %{_libdir}/python%{pythonver}/vendor-packages/xdg/*

Same question, are there .pyo files?
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWpython-zope-interface.spec)
> 
> #
> # spec file for package SUNWpython-zope-interface
> #
> # Owner: dkenny
> #

Copyright.


> %files
> %defattr (-, root, bin)
> %dir %attr (0755, root, bin) %{_libdir}
> %dir %attr (0755, root, bin) %{_libdir}/python%{python_version}
> #%dir %attr (0755, root, bin) %{_libdir}/python

pls delete

> %{python_version}/vendor-packages
> %{_libdir}/python%{python_version}/vendor-packages

same Q about .pyo files.
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWrdesktop.spec)
> 
> #
> # spec file for package SUNWrdesktop
> #
> # Owner: migi
> #

Copyright header.
Otherwise okay.

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWrrdtool.spec)
> 
> #
> # spec file for package SUNWrrdtool
> #
> # Owner: migi
> #

copyright

> # This source is gcc-centric, therefore...
> export CC=/usr/sfw/bin/gcc
> # export CFLAGS="%optflags"
> export CFLAGS="-O4 -fPIC -DPIC -Xlinker -i -fno-omit-frame-pointer"

use export CFLAGS="%gcc_optflags" instead
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWxdg-user-dirs.spec)
> 
> #
> # spec file for package SUNWxdg-user-dirs
> #
> # Owner: dkenny
> #

Copyright.

> %include Solaris.inc
> 
> Name:                SUNWxdg-user-dirs
> Summary:             Tool to help manage user directories
> Version:             0.9
> Source:
> http://user-dirs.freedesktop.org/releases/xdg-user-dirs-%{version}.tar.gz
> Source1:             xdg-user-dirs-update.desktop
> Patch0:              xdg-user-dirs-01-bugs.diff

Patch comments please.

> SUNW_BaseDir:        %{_basedir}
> BuildRoot:           %{_tmppath}/%{name}-%{version}-build
> %include default-depend.inc
> 
> Requires: %name-root
> 
> %package root
> Summary:             %{summary} - / filesystem
> SUNW_BaseDir:        /
> %include default-depend.inc
> 
> 
> %prep
> %setup -q -n xdg-user-dirs-%{version}
> %patch0 -p1
> 
> 
> %build
> CPUS=`/usr/sbin/psrinfo | grep on-line | wc -l | tr -d ' '`
> if test "x$CPUS" = "x" -o $CPUS = 0; then
>      CPUS=1
> fi
> 
> export LDFLAGS=-lglib-2.0

Should probably be "%_ldflags -lglib-2.0" or even
"%_ldflags `pkg-config --libs glib-2.0`"

also set CFLAGS to %optflags
> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWxdg-utils.spec)
> 
> #
> # spec file for package SUNWxdg-utils
> #
> # Owner: dkenny
> #

Copyright.
Otherwise looks good, if there is not C code in it.

> 
> 
> 
> 
> 
> 
> rpm spec file
> attachment
> (SFEswig.spec)
> 
> #
> # Copyright (c) 2008 Sun Microsystems, Inc.

yay :)
(although I think the (c) shouldn't be there ;)

> # This file and all modifications and additions to the pristine
> # package are under the same license as the package itself.
> #
> # spec file for package SFEswig
> #
> # includes module(s): swig
> #

# Owner please

Otherwise looks good.

> 
> 
> 
> 
> rpm spec file
> attachment
> (SUNWlcms.spec)
> 
> #
> # spec file for package SUNWlcms
> #
> # temp spec for lcms until SFW integrate it
> #

I'm ignoring it so.

Thanks,
Laca



Reply via email to