Laca,
Thanks for reviewing, comments below. Attach the updated spec files
again.
Halton.
> > rpm spec file attachment (SUNWdesktop-search.spec)
> >
> > #Additional recommended packages
> > Requires: SUNWgnome-media
> > Requires: SUNWpng
> > Requires: SUNWogg-vorbis
> > Requires: SUNWlibexif
> > Requires: SUNWgnome-pdf-viewer
> > Requires: SUNWlxsl
> > Requires: SUNWdesktop-search-libs
>
> So are these "recommended" or required?
Remove this comment
>
> > %package extension
> > Summary: %{summary} - extension files
>
> What are they?
>From comments below, seems you understand what are they. Yes, they are
firefox and thunderbird extension.
>
> > SUNW_BaseDir: %{_basedir}
> > %include default-depend.inc
> > Requires: %name
> >
>
> > # Install firefox extension
> > mkdir -p $RPM_BUILD_ROOT%{_libdir}/firefox/extensions
> > cd $RPM_BUILD_ROOT%{_libdir}/firefox/extensions
> > mkdir \{fda00e13-8c62-4f63-9d19-d168115b11ca\}
> > cd \{fda00e13-8c62-4f63-9d19-d168115b11ca\}
> > unzip %SOURCE1
> > # FIXME: delete this link when firefox3 is removed or it is default
> > mkdir -p $RPM_BUILD_ROOT%{_libdir}/firefox3/extensions
> > cd $RPM_BUILD_ROOT%{_libdir}/firefox3/extensions
> > ln -s ../../firefox/extensions/\{fda00e13-8c62-4f63-9d19-d168115b11ca\}
> > \{fda00e13-8c62-4f63-9d19-d168115b11ca\}
>
> Where is this magic number coming from?
> In any case, I suggest you use a macro or a variable to avoid typos.
Good idea, apply.
>
> > # Install firefox extension
> > mkdir -p $RPM_BUILD_ROOT%{_libdir}/thunderbird/extensions
> > cd $RPM_BUILD_ROOT%{_libdir}/thunderbird/extensions
> > mkdir \{b656ef18-fd76-45e6-95cc-8043f26361e7\}
> > cd \{b656ef18-fd76-45e6-95cc-8043f26361e7\}
> > unzip %SOURCE2
>
>
> > %files extension
> > %defattr (-, root, bin)
> > %dir %attr (0755, root, bin) %{_libdir}
> > %{_libdir}/firefox*
> > %{_libdir}/thunderbird
>
> Okay, so the "extension" package includes ff and tb extensions
> for tracker? Hmm... I would prefer to have them in 2 separete
> pkgs: SUNWdesktop-search-firefox and SUNWdesktop-search-thunderbird,
> dependant upon SUNWfirefox and SUNWthunderbird respectively.
Accept, need I send the package name request to RE again?
>
> > %files root
> > %defattr (-, root, sys)
> > %dir %attr (0755, root, sys) %{_sysconfdir}
> > %{_sysconfdir}/*
>
> I'm not sure what's in the root pkg (maybe the %files root section
> should be more explicit?) but SUNWdesktop-search should probably
> depend on it.
There are autostart .desktop files in. Change like below more
specifically,
%files root
%defattr (-, root, sys)
%dir %attr (0755, root, sys) %{_sysconfdir}
%dir %attr (0755, root, sys) %{_sysconfdir}/xdg
%dir %attr (0755, root, sys) %{_sysconfdir}/xdg/autostart
%{_sysconfdir}/xdg/autostart/*.desktop
Need run postscript for this?
>
> >
> >
> >
> >
> >
> >
> > rpm spec file
> > attachment
> > (SUNWdesktop-search-libs.spec)
> >
>
>
> > Requires: SUNWpostrun
>
> Only the root pkg seems to use postrun so this shouldn't be
> needed.
Removed. Add Requires: SUNWdesktop-search-libs-root
>
> > #remove unused files
> > rm -rf $RPM_BUILD_ROOT%{_mandir}/ja
>
> Japanese man pages? Shouldn't they go into the l10n pkg
> instead?
>
>
> > %post root
> > ( echo 'test -x /usr/bin/gconftool-2 || {';
> > echo ' echo "ERROR: gconftool-2 not found"';
> > echo ' exit 0';
> > echo '}';
> > echo 'umask 0022';
> > echo 'GCONF_CONFIG_SOURCE=xml:merged:/etc/gconf/gconf.xml.defaults';
> > echo 'export GCONF_CONFIG_SOURCE';
> > echo '/usr/bin/gconftool-2 --makefile-install-rule
> > %{_sysconfdir}/gconf/schemas/*.schemas'
> > ) | $BASEDIR/var/lib/postrun/postrun -u -c JDS_wait
>
> Please use %include instead
Accept.
>
> >
> >
> >
> >
> >
> >
> > rpm spec file
> > attachment
> > (tracker.spec)
> >
> > #
> > # spec file for package tracker
> > #
> > # Copyright 2008 Sun Microsystems, Inc.
> > # This file and all modifications and additions to the pristine
> > # package are under the same license as the package itself.
> > #
> > # Owner:halton
> > #
> >
> > Name: tracker
> > License: GPL
> > Group: Applications/System
> > Version: 0.6.4
> > Release: 1
> > Distribution: Java Desktop System
> > Vendor: Sun Microsystems, Inc.
> > URL: http://www.tracker-project.org
> > Summary: Desktop search tool
> > Source:
> > http://www.gnome.org/~jamiemcc/tracker/tracker-%{version}.tar.bz2
> > # date:2008-01-23 owner:jerrytan type:branding
> > Patch1: %{name}-01-w3m-crash.diff
>
> Doesn't look like a branding patch to me.
JerryTan will take look at this.
>
> > # date:2008-01-23 owner:halton type:branding
> > Patch2: %{name}-02-disable-autostart.diff
>
> > # date:2008-01-23 owner:halton type:branding
> > Patch3: %{name}-03-r1071-latest.diff
>
> s/branding/feature maybe, since this is code taken from upstream
> You can also add state:upstream.
Accept
>
> > # date:2008-01-23 owner:halton type:bug
> > bugzilla:503725,503727,503960,503966,504000
> > Patch4: %{name}-04-tp-reindex.diff
>
> I don't see this patch attached to any of these bug reports,
> are these bugids correct?
These bugs are on http://bugzilla.gnome.org
>
> > # date:2008-01-23 owner:halton type:bug bugzilla:503376
> > Patch5: %{name}-05-evo-reload.diff
>
> > # date:2008-01-23 owner:migi type:branding
> > Patch6: %{name}-06-thunderbird.diff
>
> This one doesn't look like branding either.
>
> > # date:2008-01-23 owner:jerrytan type:branding
> > Patch7: %{name}-07-firefox-history.diff
>
> And neither does this. Are you guys pushing these upstream?
Will hold until tracker 0.7.x released. No schedule now, can we change
06 and 07 to feature?
>
> > # date:2008-01-23 owner:rickju type:bug bugzilla:511474
> > Patch8: %{name}-08-check-remote.diff
> > # date:2008-01-23 owner:jerrytan type:branding
> > Patch9: %{name}-09-man.diff
>
> This one needs some linguistic review, see below.
JerryTan will take look at this.
>
>
> >
> >
> >
> >
> >
> >
> > rpm spec file
> > attachment
> > (w3m.spec)
>
> looks good
> >
> >
> >
> >
> >
> >
> > rpm spec file
> > attachment
> > (libgsf.spec)
>
> looks good
> >
> >
> >
> >
> >
> >
> > differences
> > between files
> > attachment
> > (tracker-01-w3m-crash.diff)
> >
> > Index: tracker-trunk/src/trackerd/trackerd.c
> > ===================================================================
> > --- tracker-trunk/src/trackerd/trackerd.c (revision 882)
> > +++ tracker-trunk/src/trackerd/trackerd.c (working copy)
> > @@ -854,9 +854,9 @@
> > gboolean pushed_events, first_run;
> >
> > /* block all signals in this thread */
> > - sigfillset (&signal_set);
> > +// sigfillset (&signal_set);
> > #ifndef OS_WIN32
> > - pthread_sigmask (SIG_BLOCK, &signal_set, NULL);
> > +// pthread_sigmask (SIG_BLOCK, &signal_set, NULL);
> > #endif
> >
> > g_mutex_lock (tracker->files_signal_mutex);
> >
>
> Can you explain what this fixes and how? (and/or submit upstream)
JerryTan will take look at this.
>
>
> >
> >
> >
> >
> >
> >
> > differences
> > between files
> > attachment
> > (tracker-09-man.diff)
> >
> > --- docs/trackerd.1 Tue Jan 22 15:27:24 2008
> > +++ docs/trackerd.1.new Tue Jan 22 15:27:04 2008
> > @@ -100,6 +100,10 @@
> > needs a
> > .BR dbus-daemon(1)
> > to be running within your current session.
> > +.PP
> > +Please check tracker releasenotes on solaris platform on
> > +.PP
> > +\fBhttp://opensolaris\&.org/os/project/jds/tasks/MetaTracker/\fR\&;.
> >
> > .SH SEE ALSO
> > .BR tracker-search-tool (1),
>
> We need proper wording here.
JerryTan will take look at this.
>
>
> Thanks,
> Laca
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SUNWdesktop-search.spec
Type: text/x-rpm-spec
Size: 7552 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080226/bd6f1c80/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: SUNWdesktop-search-libs.spec
Type: text/x-rpm-spec
Size: 5240 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080226/bd6f1c80/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tracker.spec
Type: text/x-rpm-spec
Size: 5005 bytes
Desc: not available
URL:
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20080226/bd6f1c80/attachment-0002.bin>
