[jds-review] jds SVN: spec-files

[Patrick Ale]

On Feb 1, 2008 12:41 AM, Damien Carbery <Damien.Carbery at sun.com> wrote:
> I think that stdout might be a reserved word in forte.
> http://bugzilla.gnome.org/show_bug.cgi?id=462440
>

Your thoughts seem to be right. When I change stdout to std_out in the
source code SUNWevolution-lib.spec builds and installs. (Patch below,
not yet applied cause I suspect this will have to go upstream).


--
Patrick



--- libsoup-2.3.0.1/tests/query-test.c.orig     2008-01-15
18:35:51.000000000 +0100
+++ libsoup-2.3.0.1/tests/query-test.c  2008-02-01 10:40:09.008002738 +0100
@@ -62,7 +62,7 @@
        GPtrArray *args;
        GHashTable *form_data_set;
        char *title_arg = NULL, *name_arg = NULL;
-       char *stdout = NULL;
+       char *std_out = NULL;

        debug_printf (1, "%2d. '%s' '%s'%s: ", n * 2 + (extra ? 2 : 1),
                      tests[n].title ? tests[n].title : "(null)",
@@ -100,17 +100,17 @@
        if (g_spawn_sync (NULL, (char **)args->pdata, NULL,
                          G_SPAWN_SEARCH_PATH | G_SPAWN_STDERR_TO_DEV_NULL,
                          NULL, NULL,
-                         &stdout, NULL, NULL, NULL)) {
-               if (stdout && !strcmp (stdout, tests[n].result))
+                         &std_out, NULL, NULL, NULL)) {
+               if (std_out && !strcmp (std_out, tests[n].result))
                        debug_printf (1, "OK!\n");
                else {
                        debug_printf (1, "WRONG!\n");
                        debug_printf (1, "  expected '%s', got '%s'\n",
                                      tests[n].result,
-                                     stdout ? stdout : "(error)");
+                                     std_out ? std_out : "(error)");
                        errors++;
                }
-               g_free (stdout);
+               g_free (std_out);
        } else {
                debug_printf (1, "ERROR!\n");
                errors++;