Alfred Peng wrote:
> Hi Brian,
>
> Brian Lu wrote:
>
>> @@ -264,7 +289,7 @@
>> /usr/bin/find security/nss/lib/ -name '*.h' -type f -exec /bin/cp {} \
>> $RPM_BUILD_ROOT/%{_includedir}/firefox/nss/ \;
>> %else
>> -find $RPM_BUILD_ROOT/%{_includedir} -name "nss*" -o -name "nspr*" \
>> +$RPM_BUILD_ROOT/%{_libdir}/%{name}/include \( -name "nss*" -o -name
>> "nspr*" \
>> -type f | xargs rm -f
>>
> Typo here? The command "find" seems to be missing.
>
>
Yes, "find" is missed. I'll add it.
>> LIBS += \
>> $(STATIC_COMPONENTS_LINKER_PATH) \
>> - $(EXTRA_DSO_LIBS) \
>> $(MOZ_JS_LIBS) \
>> $(APP_XPCOM_LIBS) \
>> $(NSPR_LIBS) \
>> $(TK_LIBS) \
>> + $(EXTRA_DSO_LIBS) \
>> $(NULL)
>>
> Any reason to change the place for $(EXTRA_DSO_LIBS)?
>
The reason is that EXTRA_DSO_LIBS=-lxul and it should be linked last or
some symbols will bind to libxul.so instead of libxpcom.so. This will
cause firefox
crash.
> Cheers,
> -Alfred
>
