Forgot attaching the patch. - Jerry
jijun yu wrote: > Hi Brian, > > Thanks a lot for you review and your advices. > I have remade the patches as you suggested. > > Regards, > Jerry > > Brian Cameron wrote: >> >> Jerry: >> >>> Attached are the patches for fixing bug 6689985-Totem plugin registered >>> file mimetypes that it could not handle. Please review. >>> >>> The patches removed some plugins including libtotem-gmp, >>> libtotem-narrowspace, libtotem-mully and libtotem-cone and also some >>> mime types including flv, mp3 from libtotem-basic plugin, because >>> they are not supported on Solaris. >> >> It would probably be better to add a configure option to disable >> building certain totem plugins, since this type of patch could go >> upstream. This is better than just removing files after installing. >> >> Actually, looking at the totem configure script it seems to already >> have --disable-gmp-plugin, --disable-narrowspace-plugin, >> --disable-mully-plugin, --disable-cone-plugin. Why aren't we using >> these instead. This seems more clean to me. >> >> I also was disappointed to see that there were no comments to explain >> why we were removing these plugins. In the future, we may be able to >> add support for some of these plugins (if we get license, for example). >> Adding comments helps us, in the future, to know if/when we can >> re-enable them. >> >> I added this comment to the spec file just now. >> >> # We remove the following totem plugins since they are used for >> # media types that are not supported on Solaris: >> # >> # - GMP = Windows Media >> # - narrowspace = QuickTime >> # - MullY = DivX >> # - Cone = VLC >> # >> >> Note that if you fix the spec files to add configure options to disable >> the plugins, you can simply move the above comment to above the call >> to configure in the base-specs/totem.spec file. >> >> Brian > -------------- next part -------------- An embedded and charset-unspecified text was scrubbed... Name: patch URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20080428/dbaf9d46/attachment.ksh>
