Although this is a very basic patch, I am sending it for review because 
I am unsure whether it is the right solution.

libgnomeprint 2.18.0 fails with the following compilation error:
"gpa-utils.c", line 118: operands have incompatible types:
          pointer to unsigned char ":" pointer to char

I changed:
-g_print (" {%s}", ((GPAKey *) node)->value ? ((GPAKey *) node)->value : 
"");
+g_print (" {%s}", ((GPAKey *) node)->value ? ((GPAKey *) node)->value : 
(guchar *)"");
(note the cast of the empty string).

The commit message for the change in svn.gnome.org is:
* libgnomeprint/gpa/gpa-utils.c (gpa_utils_dump_tree_with_level):
        Guard against printing NULL for %s.
http://svn.gnome.org/viewcvs/libgnomeprint/trunk/libgnomeprint/gpa/gpa-utils.c?r1=1804&r2=2240

Damien

-- 
Damien Carbery, Gnome Release Engineer
Ext: x (70) 19218
-------------- next part --------------
A non-text attachment was scrubbed...
Name: libgnomeprint-03-guchar-pointer.diff
Type: text/x-patch
Size: 618 bytes
Desc: not available
URL: 
<http://mail.opensolaris.org/pipermail/jds-review/attachments/20070314/f6f7f637/attachment.bin>

Reply via email to