vino-preferences crashes with G_DEBUG=fatal_criticals, it is because call g_base64_decode (password_b64, &blob_len), password_b64 is "", give critical warning, and then crashes.
This patch check password_b64 and *password_b64 before call g_base64_decode, can fix this problem. But I think it is actually a glib bug, when password_b64 is "", g_base64_decode will cause g_base64_decode_step(text, inlen, ret, &state, &save), ret is NULL, then generate this warning. Give g_base64_decode source code url for reference. http://svn.gnome.org/viewcvs/glib/trunk/glib/gbase64.c?view=markup Anyway, fix in vino first. -------------- next part -------------- A non-text attachment was scrubbed... Name: vino-01-crash-critical-warning.diff Type: text/x-patch Size: 510 bytes Desc: not available URL: <http://mail.opensolaris.org/pipermail/jds-review/attachments/20070316/b79b0d10/attachment.bin>
