Thank you for that, please commit!
Laca
On Fri, 2007-03-16 at 17:42 +0900, Takao Fujiwara - Tokyo S/W Center
wrote:
> Could you review the following reply?
>
> Thanks,
> fujiwara
>
> --- spec-files/po-sun/README (revision 10887)
> +++ spec-files/po-sun/README (working copy)
> @@ -24,6 +24,100 @@
> #
>
>
> +What is the "SUN_BRANDING" tag
> +==============================
> +
> + The purpose is to extract Sun specific messages on GUI.
> + CLI warning messages don't have to be translated but we need
> + translations with visible GUI.
> + I'ld like to extract the Sun specific message strings when adding
> + new strings and/or changing community strings for community packages.
> +
> +
> +Supported file types
> +====================
> +
> + .c, .h, .py,
> + .desktop.in, .directory.in,
> + .sh.in,
> + .server.in,
> + .kbd.in,
> + .xml[.in],
> + .shcemas.in,
> + .glade [1]
> +
> +
> +Comment format per File type
> +============================
> +
> + - .c, .h, .py
> +
> + /* SUN_BRANDING
> + This is a comment line. */
> + _("C string");
> +
> +
> + - .desktop.in, .directory.in
> +
> + # SUN_BRANDING
> + _Name=C string
> + # SUN_BRANDING
> + _Comment=C string
> +
> +
> + - .sh.in [2]
> +
> + #!/bin/bash
> + # SUN_BRANDING
> + printf $"C string"
> +
> +
> + - .server.in
> +
> + <!-- SUN_BRANDING
> + This is a comment line. -->
> + <oaf_attribute name="name" type="string" _value="C string"/>
> +
> +
> + - .kbd.in
> +
> + <!-- SUN_BRANDING
> + This is a comment line. -->
> + <_GOK:label>C string</_GOK:label>
> +
> +
> + - .xml[.in]
> +
> + <!-- SUN_BRANDING
> + This is a comment line. -->
> + <foo _name="C string">
> +
> +
> + - .shcemas.in
> +
> + <locale name="C">
> + <default><!-- SUN_BRANDING
> + This is a comment line. -->C string</default>
> + </locale>
> +
> +
> + - .glade
> +
> + <property name="title" translatable="yes"
> comments="SUN_BRANDING">C string</property>
> +
> +
> +FIXME:
> +1. .theme and .icon files are not defined the comment "^#".
> +http://standards.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html
> +2. Comments in .keys.in are not extracted by intltool-update.
> +3. Need tests to work fine with comments in .cave and .soundlist files.
> +
> +Requirement: intltool 0.35.5 or later
> +
> +[1] Also works .in.in. files. e.g. desktop.in.in
> +[2] It seem bash 3.0 i18n doesn't work on none UTF-8 so need to convert from
> UTF-8.
> +
> +
>
>
> Laszlo (Laca) Peter wrote:
> > Sure. But I need more details.
> >
> > What types the files need these tags?
> > What's the format of the tags in each of these file types?
> > What else do we need to do when adding new strings or changing
> > community strings?
> > That sort of stuff.
> >
> > Thanks,
> > Laca
> >
> > On Thu, 2007-03-15 at 16:07 +0800, Brian Cameron wrote:
> >
> >>Glynn/Takao/Laca:
> >>
> >>If we're supposed to put this tag in our spec files and patches
> >>where branding is used, should this step be added to our process?
> >>
> >>http://opensolaris.org/os/project/jds/documents/code_review/
> >>
> >>Brian
> >>
> >>
> >>
> >>>Takao Fujiwara - Tokyo S/W Center wrote:
> >>>
> >>>>The purpose is to extract Sun specific messages on GUI.
> >>>>CLI warning messages don't have to be translated but we need
> >>>>translations with visible GUI.
> >>>>I'ld like to extract the Sun specific message strings.
> >>>
> >>>Okay, that's what I figured. It's probably something I need to become
> >>>aware of
> >>>when creating other patches. I've fixed the panel patch and committed now.
> >>>
> >>>
> >>>Glynn
> >>
> >
> >
>
>
